From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 5A1533857C61 for ; Sun, 20 Sep 2020 20:19:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5A1533857C61 Received: by mail-wm1-x344.google.com with SMTP id q9so10154380wmj.2 for ; Sun, 20 Sep 2020 13:19:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gFUhIraxKJs6eKpagIDMMBdjkIPO8vTyHgoDTFEqPJ0=; b=T5Z/2Vl1yZLRndZSq49JJPKg2YR/kWotcunPYCjZDIhee3WIwZuJFZu4LWUy4uhb0S 210gzpU5I4EIdR/awkactYwJXruZ5HQQopqBAs1+5GdMlwizmFOJRtMn1pBEJ9axHFyv Y737LXQSRbbO3ytBMhRxUbSrmVvUb6AGfbDNRL3U4y9EI/t9kxYWD3N0weiYJH6ZKUWg ylh5+6gN83Qx4Vr/4HBNHJoRXyJR+wbjRYs1jxf9y8PxDLBkmuYaKlV7dNXo678dHuc1 sSeK3A6+0GTDDsocWO1Gc4FmeO28sBxEiiKErrInDI6CmOKf6NL84MtBv3agiNTpXpSc H48Q== X-Gm-Message-State: AOAM531W/dfxy+C35nJuxehIGdbI91GgiwHApzXQFKgbY2CEWh6o/X5I gJzRlIrwaqJDiVisZyunLShMAkQ6kUk= X-Google-Smtp-Source: ABdhPJxr+iEH0QjIt2u2D1gAV4ixkdB5TesfNVciA3Qg9Xj13IMtlQTCr5+FegCjBGN55zhP/LBToQ== X-Received: by 2002:a1c:5685:: with SMTP id k127mr27635248wmb.135.1600633189028; Sun, 20 Sep 2020 13:19:49 -0700 (PDT) Received: from ?IPv6:2001:a61:2479:6801:d8fe:4132:9f23:7e8f? ([2001:a61:2479:6801:d8fe:4132:9f23:7e8f]) by smtp.gmail.com with ESMTPSA id a11sm15802529wmm.18.2020.09.20.13.19.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Sep 2020 13:19:48 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v2 8/9] system_data_types.7: Document siginfo_t To: Alejandro Colomar References: <20200920180551.63608-1-colomar.6.4.3@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Sun, 20 Sep 2020 22:19:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200920180551.63608-1-colomar.6.4.3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Sep 2020 20:20:10 -0000 Hello Alex, On 9/20/20 8:05 PM, Alejandro Colomar wrote: > Note: There are a few members off this structure that are > not required by POSIX (XSI extensions, and such). > > I simply chose to not document them at all. > > Signed-off-by: Alejandro Colomar > --- > > Hello Michael, > > Clearly I needed the weekend! > Here's the patch as it should have been. Thanks! Patch applied. Some notes below. > man7/system_data_types.7 | 39 ++++++++++++++++++++++++++++++++++++--- > 1 file changed, 36 insertions(+), 3 deletions(-) > > diff --git a/man7/system_data_types.7 b/man7/system_data_types.7 > index a7955f331..080f0057f 100644 > --- a/man7/system_data_types.7 > +++ b/man7/system_data_types.7 > @@ -213,6 +213,39 @@ See also: > See also the > .I aiocb > structure in this page. > +.\"------------------------------------- siginfo_t --------------------/ > +.TP > +.I siginfo_t > +.IP > +Include: > +.IR ; > +or > +.IR . > +.IP > +.EX > +typedef struct { > + int si_signo; /* Signal number */ > + int si_code; /* Signal code */ > + > + pid_t si_pid; /* Sending process ID */ > + uid_t si_uid; /* Real user ID of sending process */ > + void *si_addr; /* Address of faulting instruction */ > + int si_status; /* Exit value or signal */ > + > + union sigval si_value; /* Signal value */ > +} siginfo_t; Some minor white space issues in the above structure (blank lines, misaligned comments); I fixed them. > +.EE > +.\".IP > +.\" FIXME: Add a description? Generally, I think we always should have a description, even if very short. I added one, mainly in the form of a reference to sigaction(2). > +.IP > +Conforming to: POSIX.1-2001 and later. > +.IP > +See also: > +.BR pidfd_send_signal (2), > +.BR rt_sigqueueinfo (2), > +.BR sigaction (2), > +.BR sigwaitinfo (2), > +.BR psiginfo (3) That list is "just right"; thanks. > .\"------------------------------------- sigval -----------------------/ > .TP > .I sigval > @@ -239,9 +272,9 @@ See also: > See also the > .I sigevent > structure > -.\"and the > -.\".I siginfo_t FIXME > -.\"type > +and the > +.I siginfo_t > +type > in this page. > .\"------------------------------------- size_t -----------------------/ > .TP Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/