From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 78F3438582A1 for ; Wed, 1 Feb 2023 17:54:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78F3438582A1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pj1-x1031.google.com with SMTP id cq16-20020a17090af99000b0022c9791ac39so2997510pjb.4 for ; Wed, 01 Feb 2023 09:54:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h3HEqyjJs6WcZFm4tFmXupYW1Q99GguULcELQP/wwJE=; b=QTWdow5RAtJO4IT4KfCiBwe1HpA1clT2INrFkCxFeUmumewuGN9fW75+l16CyxYotL fdWN1f06whkHnoz3FKRf+VaxtgL273Celf1hXhECnJEDDkvv0n8/gi4Ac713XTZu/QRc A69V6hU77QqmyVslRnRMtG3i5wRcrndNLlRDBMTCpBEUQjXu5KFPkdnScr1F3DP7tb5Q 6VulNiTE+25c4fs9+hZiQGM8sF4xZ7IWS5wkx3un7McUJJoK0T/ifCJlbBJIiSvCatR5 nR0zJPfUpSH3WbxSemQBEeo0F4wa9PK3Dd9RrMFe9wbC1g5j8Zbz1NgO3LeseruCp1cB S66g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h3HEqyjJs6WcZFm4tFmXupYW1Q99GguULcELQP/wwJE=; b=i4jVsRTqNB5TRZpKCWrbMMpO76Y5QBbLBfmURwqtCyqWOyxy1EyJdAWBTz/8xG5GC0 3MMSWzhJoPwTQ3hsEGGoUqHu9eAgn491O5ln8WN4Cu/6DhApFCTehcCK9DTnBVhxO123 PrZq40iM0gdRf5SI0gbVNt53WB6HlX3uqNaWlySuAEQWDZco6MqDflkwsX6PJ7f03y7z MwtbsPwumulJSy2zXp7fvGTvC5j05smMrzsvJQB/tGE/vfOrqsD16pXO8FQd/ncS2MPb 15Qcg8Bmr+lL//ijc/wEF2Jde0hP37P+xg/E1O51fvIAyj6KQlIgg/ETxJKLxjCImw0p XGXg== X-Gm-Message-State: AO0yUKUzs69d+kI/EQvffsT+vP84V930CBt1XM0A8hdoDJ7HtBtq6sea NfkiZZ9LWVyvOgV3aRhBqGbJBMI/uFiNZkEg X-Google-Smtp-Source: AK7set9b1XfSIzB0PS++1TKKsj3+jXmEq/mSZFCOGl3/PHOFtv909lhFY3vb43bFf62Bi/29eEvV7Q== X-Received: by 2002:a17:902:d4cd:b0:196:349f:4df3 with SMTP id o13-20020a170902d4cd00b00196349f4df3mr4537088plg.50.1675274061547; Wed, 01 Feb 2023 09:54:21 -0800 (PST) Received: from [192.168.50.50] (rrcs-173-197-98-118.west.biz.rr.com. [173.197.98.118]) by smtp.gmail.com with ESMTPSA id l2-20020a170902ec0200b00198a96c6b7csm2055254pld.305.2023.02.01.09.54.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 09:54:21 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 07:54:18 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v11 21/29] string: Hook up the default implementation on test-strlen Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org, Noah Goldstein , Jeff Law , Xi Ruoyao References: <20230201170406.303978-1-adhemerval.zanella@linaro.org> <20230201170406.303978-22-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20230201170406.303978-22-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/1/23 07:03, Adhemerval Zanella wrote: > Also remove the simple_STRLEN and builtin_strlen, which are not used > anywhere. > --- > string/test-strlen.c | 31 ++++++++++++++----------------- > 1 file changed, 14 insertions(+), 17 deletions(-) Reviewed-by: Richard Henderson r~ > > diff --git a/string/test-strlen.c b/string/test-strlen.c > index 81adf23737..0f98576f40 100644 > --- a/string/test-strlen.c > +++ b/string/test-strlen.c > @@ -37,27 +37,24 @@ > > typedef size_t (*proto_t) (const CHAR *); > > -/* Naive implementation to verify results. */ > -size_t > -simple_STRLEN (const CHAR *s) > -{ > - const CHAR *p; > - > - for (p = s; *p; ++p); > - return p - s; > -} > +IMPL (STRLEN, 1) > > +/* Also check the generic implementation. */ > +#undef STRLEN > +#undef weak_alias > +#define weak_alias(a, b) > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(a) > #ifndef WIDE > -size_t > -builtin_strlen (const CHAR *p) > -{ > - return __builtin_strlen (p); > -} > -IMPL (builtin_strlen, 0) > +# define STRLEN __strlen_default > +# include "string/strlen.c" > +IMPL (__strlen_default, 1) > +#else > +# define WCSLEN __wcslen_default > +# include "wcsmbs/wcslen.c" > +IMPL (__wcslen_default, 1) > #endif > > -IMPL (STRLEN, 1) > - > > static void > do_one_test (impl_t *impl, const CHAR *s, size_t exp_len)