From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 1424E385781D for ; Mon, 29 Mar 2021 20:44:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1424E385781D Received: by mail-qk1-x72c.google.com with SMTP id c3so13814333qkc.5 for ; Mon, 29 Mar 2021 13:44:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eArurOp6b1bKK+0j+fgEldm3OzZCIgHh8X2TLSqmYBs=; b=sTpZEVAkMNfCXF06DLowIHV2X03QzDJaH0OEzXcJ7pYVRTRZjmBKnRm3nCOXew1bQ6 Yxql7rcaBfeBC4jBSHBuw9Vr6sgc1+0UeUFZsAyqEwME1YQEkVxmp1IaJKRzKpcWXuL6 ZqXNiq8xwajzg12xOucYEFPfaR1sTdU+Yy9ys50ri8zzV//mkWfxoRciJEpv0Pyn7cms HCnas+LmAXvxEGfhdIQnM0HQP5wwScgSg3pBBfow1vLDZzuiC0PqEf0sazu7esO58YVo Igph7j8ep/ybb8GSzX6TsZvbiks4Pu11PryLgR8PDM7cTKmz/0DRwg68cM3N8bOTyYWg cVFQ== X-Gm-Message-State: AOAM531YqhghWflqalUdAsGYiMdIYwezY6XMxVCWQdh1v61Q9mMOsU65 GG+SFgbXl0jLcpjW1o2L4xBRrF+BXBW4A8Eq X-Google-Smtp-Source: ABdhPJw3yvu4GlSWDzpjx/E+/+pomUBq2D48Oc/2Fa+z4S7yNXeMQZTaVw3wKoEnDGbp/UxzIIYF8A== X-Received: by 2002:a05:620a:2206:: with SMTP id m6mr26882610qkh.176.1617050639690; Mon, 29 Mar 2021 13:43:59 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id i8sm11599950qtj.16.2021.03.29.13.43.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 13:43:59 -0700 (PDT) Subject: Re: [PATCH] stdio-common/printf-prs.c: Simplify test To: "Alejandro Colomar (man-pages)" , libc-alpha@sourceware.org References: <20210324180718.28006-1-alx.manpages@gmail.com> <0a435dd4-2ea3-952e-d8bf-72cf3a7b6105@linaro.org> <4ad8aa37-2efa-3eb5-3c10-455993ef6cb7@gmail.com> From: Adhemerval Zanella Message-ID: Date: Mon, 29 Mar 2021 17:43:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <4ad8aa37-2efa-3eb5-3c10-455993ef6cb7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 20:44:05 -0000 On 29/03/2021 17:35, Alejandro Colomar (man-pages) wrote: > > > On 3/29/21 9:32 PM, Adhemerval Zanella wrote: >> >> >> On 24/03/2021 15:07, Alejandro Colomar via Libc-alpha wrote: >>> The test was being repeated for all the remaining code in the for loop. >>> Test once, and 'continue' to next iteration if necessary, so that the >>> following code can assume that the necessary condition is met. >>> >>> Minor changes: fix some mixed tabs & spaces to use spaces only. >>> >>> Signed-off-by: Alejandro Colomar >> >> We do not use SCO, but rather Copyright assignment. And I think we will >> need to add a testcase for this change, this simple program below shows >> a complete different result with this patch applied: >> > > Hello Adhemerval, > > Yes, I was completely wrong with that patch. I submitted a patch v2 > after that, trying to improve the comments (without the code changes, > which were wrong) to avoid confusion: > . Ok, I will review this one and mark this as superseded.