From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by sourceware.org (Postfix) with ESMTPS id 08FD83857029 for ; Tue, 8 Mar 2022 13:55:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08FD83857029 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4506A881679; Tue, 8 Mar 2022 13:45:39 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D5B9288111F; Tue, 8 Mar 2022 13:45:38 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1646747138; a=rsa-sha256; cv=none; b=W+58tdIOtr0nxTUHbuz33ftSBWwys/SGYS4jGn8HLmEQfR/QECXDMujmfxPxuxbOiFSHLK 6PgHbF+jkJ/rA0T/7T4kiiYR7dpCs4e7GEfAK69OB7uRVRd/kPui18UCJENwnvR1vqcATn AxLTKgjScmaviBKIW0U4V5dwA/ccpcc8UlvH41o+92upW2IOA0AihPv9RmVaalhx0pZhgb FXnM3aIuEIhEB5HXic+Ri9O246ztI6ex8qRKDSRuka7acM2aETwrhZ0UvxjJeuEZHFyTBx XTexFPLD26tCv3MOP9GZQXZoQ+MHfC6ZbHBs/1lx4XFeJRAHWOfdQhwaVuDofw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1646747138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=URG/UPJrDbZifC3mLffbLi2RzWkowm2zV+lLZuwa7P4=; b=Qp6p8bKRhywqgzQXUakUhwicnX5RwmNMC2oX3ltD3DtgplLYjFwjJyID9GdIEkqyjbHhCj jpaLWJkY6p7vn+ooa69YTGmgu97/B2zafsjlUjNQIqmfmazM/chKECXihjOEMXc9KnE3uU 3BkD8CxrRrnbos4BMbp4oKcsNmNau3zsXinADOQOUBiiquAW3H4dFhC/wVAY/3dYdWGtHK LMEuTv7zF36wpdLu82ppeoCfu2Hl2dbSkvcIdNLRoKFKyhNBhedm/qs+Vn7eepORrVOgxI HVg089fHddCJAf+AQjMQBX+eFdIHLRw3E+3KdGz69WkGFd5HaEa7CnKgEuhaPQ== ARC-Authentication-Results: i=1; rspamd-c9cb649d9-7z87n; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.103.158.113 (trex/6.5.3); Tue, 08 Mar 2022 13:45:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Shelf-Quick: 32d092e70eb52ce8_1646747139162_1754308422 X-MC-Loop-Signature: 1646747139162:2935101401 X-MC-Ingress-Time: 1646747139162 Received: from [192.168.1.174] (unknown [1.186.224.155]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4KCc691Cncz1Nq; Tue, 8 Mar 2022 05:45:36 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 19:15:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 03/12] getaddrinfo: Fix leak with AI_ALL [BZ #28852] Content-Language: en-US To: Andreas Schwab , Siddhesh Poyarekar via Libc-alpha Cc: fweimer@redhat.com References: <20220308100717.1006126-1-siddhesh@sourceware.org> <20220308100717.1006126-4-siddhesh@sourceware.org> <871qzcr9o3.fsf@igel.home> From: Siddhesh Poyarekar In-Reply-To: <871qzcr9o3.fsf@igel.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3486.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 13:55:30 -0000 On 08/03/2022 16:30, Andreas Schwab wrote: > On Mär 08 2022, Siddhesh Poyarekar via Libc-alpha wrote: > >> @@ -212,10 +209,30 @@ convert_hostent_to_gaih_addrtuple (const struct addrinfo *req, >> if (count == 0 || h->h_length > sizeof (((struct gaih_addrtuple) {}).addr)) >> return true; >> >> - struct gaih_addrtuple *array = calloc (count, sizeof (*array)); >> + struct gaih_addrtuple *array = *result; >> + size_t old = 0; >> + >> + while (array) > > array != NULL > Thanks, fixed locally. Siddhesh