From: "Junxian Zhu" <zhujunxian@oss.cipunited.com>
To: "Adhemerval Zanella Netto" <adhemerval.zanella@linaro.org>,
<libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] benchtests: Add more benchtests for rounding functions.
Date: Thu, 25 Jan 2024 21:22:21 +0800 [thread overview]
Message-ID: <b4ed32fe-da35-457f-994b-e034480128cb@oss.cipunited.com> (raw)
In-Reply-To: <d92a0beb-7940-4ba8-adf1-1d5b3ffd5b0d@linaro.org>
在 2024/1/25 20:07, Adhemerval Zanella Netto 写道:
>
> On 21/01/24 23:16, Junxian Zhu wrote:
>> From: Junxian Zhu <zhujunxian@oss.cipunited.com>
>>
>> This patch adds more benchtests for rounding functions.
>> The double inputs are copied from trunc-inputs, the float inputs are copied from truncf-inputs. and the rintf is copied from rint-inputs.
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
>> ---
>> benchtests/Makefile | 11 +++++++++++
>> benchtests/ceil-inputs | 22 ++++++++++++++++++++++
>> benchtests/ceilf-inputs | 21 +++++++++++++++++++++
>> benchtests/floor-inputs | 22 ++++++++++++++++++++++
>> benchtests/floorf-inputs | 21 +++++++++++++++++++++
>> benchtests/llrint-inputs | 22 ++++++++++++++++++++++
>> benchtests/llrintf-inputs | 21 +++++++++++++++++++++
>> benchtests/lrint-inputs | 22 ++++++++++++++++++++++
>> benchtests/lrintf-inputs | 21 +++++++++++++++++++++
>> benchtests/nearbyint-inputs | 22 ++++++++++++++++++++++
>> benchtests/nearbyintf-inputs | 21 +++++++++++++++++++++
>> benchtests/rintf-inputs | 7 +++++++
>> 12 files changed, 233 insertions(+)
>> create mode 100644 benchtests/ceil-inputs
>> create mode 100644 benchtests/ceilf-inputs
>> create mode 100644 benchtests/floor-inputs
>> create mode 100644 benchtests/floorf-inputs
>> create mode 100644 benchtests/llrint-inputs
>> create mode 100644 benchtests/llrintf-inputs
>> create mode 100644 benchtests/lrint-inputs
>> create mode 100644 benchtests/lrintf-inputs
>> create mode 100644 benchtests/nearbyint-inputs
>> create mode 100644 benchtests/nearbyintf-inputs
>> create mode 100644 benchtests/rintf-inputs
Thanks for your review. Can you push it into master please? I have no
permission to do that.
next prev parent reply other threads:[~2024-01-25 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 2:16 Junxian Zhu
2024-01-25 12:07 ` Adhemerval Zanella Netto
2024-01-25 13:22 ` Junxian Zhu [this message]
2024-01-25 14:24 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4ed32fe-da35-457f-994b-e034480128cb@oss.cipunited.com \
--to=zhujunxian@oss.cipunited.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).