From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by sourceware.org (Postfix) with ESMTPS id 6086D3858C3A for ; Tue, 21 Dec 2021 17:03:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6086D3858C3A Received: by mail-qt1-x832.google.com with SMTP id v22so13425345qtx.8 for ; Tue, 21 Dec 2021 09:03:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Q7/47OZ6MbAJBHiUdcYtcjotvlflsUKE7P5p28SaWi0=; b=j1B3CpID/fkJbw1GMno/E2je27RmA54vk5jvtZeMu+OPfFcA20vEAVYiS3WzBWJFqF tnAoVbYe80c26BtMQ0+eNtkQZAiW6BKG5vURGInrlydRB6srtWDwm2Z/83SoaTvFumJs WmUF6xbj6/KW8ISBKaKKXSgfrzmlr3X4boKIicbWmztp6c/LpjzxiNw1Rz+SFgVrBSUl JRXQkO30IxZYqX56GrEtiOz8o8Xm7+F7rf/Ef3nB72+ePckQrQBQWpD0pUUGgyqAPPBA S34CJ88KMxr0Vq3S2XgAhh6v0l1aurJ7OyGE4TLT3w5wFX6SIhfbV3xzCzKyDkThPOWE WZlQ== X-Gm-Message-State: AOAM533iovZxkncwsmw948WpxV2a3iphQS8ROaayijl81t79lWZqIf0Q +jGUm9Was/aCXAxEtIV9ksBbFA== X-Google-Smtp-Source: ABdhPJztaX6UiazZfYax12i0g2I70PjhU5Tr89Rowj263ez9rXXCq+rP/yXCgK9dXCLp6bZa5hwlxQ== X-Received: by 2002:ac8:758b:: with SMTP id s11mr2064936qtq.51.1640106230928; Tue, 21 Dec 2021 09:03:50 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:3b1e:8bd2:32a9:e2a3:1842? ([2804:431:c7cb:3b1e:8bd2:32a9:e2a3:1842]) by smtp.gmail.com with ESMTPSA id t30sm13851002qkj.125.2021.12.21.09.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 09:03:50 -0800 (PST) Message-ID: Date: Tue, 21 Dec 2021 14:03:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 19/20] elf: Fix runtime linker auditing on aarch64 (BZ #26643) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-20-adhemerval.zanella@linaro.org> <87zgovc68b.fsf@oldenburg.str.redhat.com> <87mtku9fvd.fsf@oldenburg.str.redhat.com> <87ee669fey.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87ee669fey.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 17:03:52 -0000 On 21/12/2021 11:54, Florian Weimer wrote: > * Adhemerval Zanella: > >>>> At least for aarch64 old audit modules are error-prone and potentially adds >>>> more subtle issues since they do not save/restore some return register that >>>> I don't see any real gain to keep supporting them. >>> >>> I disagree. la_objsearch alone is a significant use case, and I don't >>> see why it wouldn't work today. It does not need any >>> architecture-specific code whatsoever. >> >> My main problem is provide a API which undocumented and missing support >> where if users tries to replicate what other architecture does it will >> shoot in the foot. I think this is just a broken API and we should >> avoid it. > > Sorry, which API? THe audit modules one, making la_objsearch work when the rest of the possible callbacks functions might trigger undefined behavior (as per BZ#26643) does not seems to me as as good way forward. It has not bitten us before because the user case is quite limited.