From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 96D3F3854171 for ; Fri, 21 Oct 2022 18:40:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96D3F3854171 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x232.google.com with SMTP id r204so1419985oie.5 for ; Fri, 21 Oct 2022 11:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=vH6LM8FKXFEFzbuP4vXUvDEYhkdEXoGtIK/FEdM+n5A=; b=bMbH9YPuIqF/MfxMmGCkOng4WgLFtx/eVQe77YA7XiusPCOPlgXl+fjqFJtwijHAPn VV1V2RjpAI+9rqICBgbPoRXJu2gT0gVGzX02nCUIDrngJuUb4zvKutZhcuOnZ+kYJh3r LC2kvkp8qMPqptRorWM0x2vwc0O9nQtLUQMxxC75++8uaYdHbubhC+L+7BNAyrbAfqgn aVwq3ajnmVYstZzLCUpj+WCHM+6D3kfhVbUPyUIbzfdRWs7TiuaxBy63Vc7eWQn6twSn cUONY/O61JKWYh+Qxc/uAajl7tpr8D2jyVDa9om0MZ5iTGDHbjHmtOJDSJTIGDSJ9l/o K6aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vH6LM8FKXFEFzbuP4vXUvDEYhkdEXoGtIK/FEdM+n5A=; b=Cxt2iJTwbBtdhBFcAos0ueOooeNDzC8JR6I0gu5SRQroMD8sSJ/v4itRr5Y687WCXT p4FpOK4lJwQp6YN+UKmmlclBRRY1ArM92nqNy/oDjd0SbD+LfcxC0DJf0R8N9HtInzZ+ /ypFPxSNWFNytS+xNZ/dhQ8BNbxpbdaUUgaUgf++pjfZD3Zt8gPl5m11eLqmD57m35D1 Cfh5mwE897cKosbH6GRDD0/KgJ8nHZwVmUBb6tJT7v5AeHGerz9dI73diJaJABifntyT R7dIDz3ppCiqxtBHBVHL84YZ6gyNVbZeI8XodkhP7bXrW++MskbrYLTPJ2pOIpaAsoVN sRBA== X-Gm-Message-State: ACrzQf0ECGtMcT/m7ir/uO/5eRARe/8TsvoCLlNeYQKXlWUrPPbxPegw J/n0RiPOdFx2QFqHtPs0DpNG4JPM8oRpc56p X-Google-Smtp-Source: AMsMyM5b/k38QN11C8iSV1vfg+GpbBGYyGy7ArYXjudo6HFvZxw6s+BRmzLw6fOqAbJC9WHVCrIfQQ== X-Received: by 2002:a05:6808:1599:b0:354:d7f6:141a with SMTP id t25-20020a056808159900b00354d7f6141amr23964231oiw.179.1666377618899; Fri, 21 Oct 2022 11:40:18 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:7d19:5909:4ed0:fbc6:5cfd? ([2804:1b3:a7c3:7d19:5909:4ed0:fbc6:5cfd]) by smtp.gmail.com with ESMTPSA id c6-20020a056830314600b0066195c63f01sm1479943ots.12.2022.10.21.11.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 11:40:18 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 15:40:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH] elf: Introduce to _dl_call_fini Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <87zge0x8fr.fsf@oldenburg.str.redhat.com> <865a135b-fb4a-2fa2-b858-105fa0e148ac@linaro.org> <878rl9827n.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <878rl9827n.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/10/22 15:24, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> On 13/10/22 08:35, Florian Weimer via Libc-alpha wrote: >>> This consolidates the destructor invocations from _dl_fini and >>> dlclose. Remove the micro-optimization that avoids >>> calling _dl_call_fini if they are no destructors (as dlclose is quite >>> expensive anyway). >>> >> >> LGTM, I think the debug message change should be ok. Some comment on >> the old code you refactored. > > Should I fix this and repost? Reviewed-by: plus suggestions is kind of > confusing. 8-) Right it was indeed confusing from my part. I think if you are ok with the suggestions I don't think it is required to repost.