From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 48BFD385781F for ; Mon, 10 May 2021 13:40:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 48BFD385781F Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-67-UeVlZJ-WOPeycWv7cpK0GA-1; Mon, 10 May 2021 09:40:00 -0400 X-MC-Unique: UeVlZJ-WOPeycWv7cpK0GA-1 Received: by mail-qk1-f198.google.com with SMTP id v1-20020a05620a1221b02902ea88445e01so8492084qkj.9 for ; Mon, 10 May 2021 06:40:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=6Z5e0/VKI8ByV6AdIwcoNLpuiLcvyjFB9V4xQi+AP5I=; b=JvvKVQ4kxMt06YzDh2394Gb+0/U1pX3pck9JARISaQ0Q9CsyZCBPXW0sxDI6+dMjgM oA2Zpmg1h2ZSet0p2F4kQFGIeyqOTgMgz5QCFn5nUQ/CSD8jjdiSAu7XwI51/0RvqCpL YIlRpn5WNzF8CDZ78bdHUBDHCalQzM/22l4bxJPlEc0PW7yCDuQYtdW5m83Kc8rPLjGm oMPiXnAzNSDbzr5ueVEGPBL6erGqZYquAPIqhCmr5bGE+64k+WjU3g4H6+wkooah/lXP yzGgd0plqJbS3h1VJ5uiGkjaF1wnVkxnVZZk8CaFqLgmZCyTRGC/pHNX1cdCb0EiRSZX xcjg== X-Gm-Message-State: AOAM533HlD+hpAAqfKuBljPFuaHy8Oft3Ut0fI1TaP84WqwB3pjHFtiE +yEmphO9DNV/VWiIDGY/nCn4TVeyIC3UEhY325LmKpf2rpCSPessEs28cHMEMVi6Yt65EmaOR4s BEBTmlJu0P+VLV2o4iQDgwDcFPtYj6u8TtrbVHbS8aZAtPWkZunBd7dF3pRUI9Se3k4LfBw== X-Received: by 2002:a05:620a:a0d:: with SMTP id i13mr12261377qka.278.1620653999379; Mon, 10 May 2021 06:39:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx97rVa6HIqXfZRMHSWzX96ND15TsSzv0XrMsd8yKZD37XBlkkH/ok2jVGpM+QDbdgdwcBLQ== X-Received: by 2002:a05:620a:a0d:: with SMTP id i13mr12261350qka.278.1620653999128; Mon, 10 May 2021 06:39:59 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id d2sm2702643qkn.95.2021.05.10.06.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 06:39:58 -0700 (PDT) Subject: Re: [PATCH] testrun.sh: Improve --help message To: "Lucas A. M. Magalhaes" , libc-alpha@sourceware.org References: <20210503212206.1699908-1-lamm@linux.ibm.com> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Mon, 10 May 2021 09:39:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210503212206.1699908-1-lamm@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2021 13:40:03 -0000 On 5/3/21 5:22 PM, Lucas A. M. Magalhaes via Libc-alpha wrote: > The testrun.sh --help message was missing the "container" option. > Besides just adding the missing option I decide to rewrite it in the > same layout as other tools. LGTM. Reviewed-by: Carlos O'Donell > --- > Makefile | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 50f99ca611..242d36de91 100644 > --- a/Makefile > +++ b/Makefile > @@ -144,8 +144,13 @@ builddir=`dirname "$$0"` > GCONV_PATH="$${builddir}/iconvdata" > > usage () { > - echo "usage: $$0 [--tool=strace] PROGRAM [ARGUMENTS...]" 2>&1 > - echo " $$0 --tool=valgrind PROGRAM [ARGUMENTS...]" 2>&1 > +cat << EOF > +Usage: $$0 [OPTIONS] [ARGUMENTS...] > + > + --tool=TOOL Run with the specified TOOL. It can be strace, valgrind or > + container. The container will run within support/test-container. > +EOF > + > exit 1 > } > > -- Cheers, Carlos.