From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 220363858C41 for ; Fri, 19 May 2023 21:55:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 220363858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.00,178,1681200000"; d="scan'208";a="5938359" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 19 May 2023 13:55:37 -0800 IronPort-SDR: S4+fBhtvXVmwmp493ORFqG7AeRRn784dJJsygqbLKMW0ZSl9pf/pZ+JFPcc46NZvnN4jfjYdrc FMdKswXsdeZks9GILsWPXvfF+G1Tq+LOpn+hrf1/AFzl/SnxZNSLydrmzJJqk38KfqjQykjpRp cecC23pb7SQ9O3ySgf174pBlOtLkMYszgDPVwJSfEK9F9lYbElU924b5Uuvmt7syLJjauLCUH+ Y2G8nui8qsj0RGwcCukVGq3cZnlrH6W0zSnW3uKBg+h0l8+9ROg4UVRujupxWlvUoe65n7usZX Bd8= Date: Fri, 19 May 2023 21:55:33 +0000 From: Joseph Myers To: Sergey Bugaev CC: , Hector Martin Subject: Re: [RFC PATCH 1/1] io: Add FORTIFY_SOURCE check for fcntl arguments In-Reply-To: <20230519213059.3812385-2-bugaevc@gmail.com> Message-ID: References: <20230519213059.3812385-1-bugaevc@gmail.com> <20230519213059.3812385-2-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3106.6 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I'm concerned about the lack of testcases in this patch. I'm not sure of how we should be checking for compile-time errors (there are several existing tests for runtime fortification), but having this functionality without testcases seems risky. -- Joseph S. Myers joseph@codesourcery.com