From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id A61E13857819 for ; Tue, 6 Apr 2021 18:54:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A61E13857819 Received: by mail-qk1-x72e.google.com with SMTP id q26so16076580qkm.6 for ; Tue, 06 Apr 2021 11:54:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wAOCQFnjhKFuB6F5kc9nGoSj+yIZB1lFRxk25qoAx+4=; b=TIYZQpXW4XTRplC66A5uQh4dRrbkyXpWipejsAtQoOUmLOI3k24L+X4MqeakUSLJ8G OFwJ29LemrMSVUTd46qy8DyqqdtcKcgr+umWTYrxpw9euOykvwVljyFmog9CAdtwcP9I KRX8pwNqoFD2zovKMknFmMla9TCifHQTICbvzZp0YkjwI1lhjpZDmu3wTNvThuUc4rZn iMTfL+p/Foud0ycqGqcH7cM7u6Qrj0J7gfzpKOE5RhrD8nm80MlZ2dBRp6COyEOMRArM tTgi49b7gktEZRZkENrENwC0p/irSKAXFOGDefEzhfwxOpmuP68rQSBZ2E/GELR9E6Le CWvg== X-Gm-Message-State: AOAM532BNb5jBnIWXPvsA47UhYfoHi5K0iOQaNXeCtn0Rod5gwdHxswC 5kAZu4FhiWibsW4VU8HUeQ7jRXwc5YjAe8pH X-Google-Smtp-Source: ABdhPJwgGNuv/10rFEgOwIHm+cpe9MMWsCKeGW4XGROypB9Bkb2P9Eqmfg8yFVCjoEOOWImcrSOO0Q== X-Received: by 2002:ae9:e64b:: with SMTP id x11mr30249266qkl.290.1617735277999; Tue, 06 Apr 2021 11:54:37 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id 131sm16972027qkl.74.2021.04.06.11.54.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 11:54:37 -0700 (PDT) Subject: Re: [PATCH v3 36/37] nptl: Move setxid broadcast implementation into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <67a2fc1add8e478af071fc21b37c175e671e8f03.1615914632.git.fweimer@redhat.com> <7f8f38af-ed62-b7fb-aa88-590a3c9916a6@linaro.org> <87zgybl0gs.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Tue, 6 Apr 2021 15:54:35 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87zgybl0gs.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2021 18:54:40 -0000 On 06/04/2021 15:41, Florian Weimer wrote: > * Adhemerval Zanella: > >>> +/* Copyright (C) 2002-2021 Free Software Foundation, Inc. >>> + This file is part of the GNU C Library. >>> + Contributed by Ulrich Drepper , 2002. >> >> Remove the 'Contributed by' Line. > > I prefer not to. It's a copy of an existing file. And in Germany, > authors have an inalienable right to be named. I am far from Copyright expert here, but my understanding is since we do not add such 'Contributed by' anymore and Copyright assignment is what matter, it should be fine to remove even this is a copy. > >>> +static struct xid_command *__xidcmd; >> >> No need double underscore for static variables. > > Okay, I've also made some of the functions static. > > Thanks, > Florian >