From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Carlos O'Donell <carlos@redhat.com>, Florian Weimer <fw@deneb.enyo.de>
Cc: Max Gautier <mg@max.gautier.name>,
GLIBC Devel <libc-alpha@sourceware.org>
Subject: Re: Contribution Checklist - ChangeLog
Date: Thu, 20 Aug 2020 23:41:20 +0530 [thread overview]
Message-ID: <b678a8ff-34f4-19b2-72b1-5b35b75e8194@gotplt.org> (raw)
In-Reply-To: <270e209a-a0b9-1ca2-55c5-3eac44090d5d@redhat.com>
On 20/08/20 23:33, Carlos O'Donell wrote:
> I would *love* v2 of the checklist to become *live* ... are you going to:
>
> (a) Edit v1 with the ChangeLog changes.
>
> or
>
> (b) Edit v2 and propose we use that.
I just went through v2 now; looks like you wrote it early last year (and
you made it exactly how I think it ought to be!) and I updated it for
ChangeLog and left it at that. I propose we overwrite v1 with this.
I've just edited it to completely drop any mention of a ChangeLog; if
you think this looks good I'll overwrite the old checklist with it:
https://sourceware.org/glibc/wiki/Contribution%20checklist%20v2
> My opinion is that backports to stable branches should *not* update the
> ChangeLog.
>
> The ChangeLog is only valid at the time a tarball is created.
>
> If a stable branch has a release then the VCS update scripts will be used
> to update the ChangeLog.
That's a reasonable constraint. In that case it probably makes sense to
drop mention of ChangeLog in legacy contributions too:
https://sourceware.org/glibc/wiki/Legacy%20Contributions
Siddhesh
next prev parent reply other threads:[~2020-08-20 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200819154837.GA182209@ol-mgautier.localdomain>
[not found] ` <87k0xud3y7.fsf@mid.deneb.enyo.de>
[not found] ` <20200819162227.GA183107@ol-mgautier.localdomain>
[not found] ` <f0662ff8-0897-f833-f49e-09a2fabdfd7e@redhat.com>
[not found] ` <CAAHN_R1z4BqsvW7W578nbfjfb-LdL4beP0bMeJiVFF3KNajkdg@mail.gmail.com>
[not found] ` <877dttbvim.fsf@mid.deneb.enyo.de>
2020-08-20 8:42 ` Siddhesh Poyarekar
2020-08-20 17:58 ` Siddhesh Poyarekar
2020-08-20 18:03 ` Carlos O'Donell
2020-08-20 18:11 ` Siddhesh Poyarekar [this message]
2020-08-22 17:05 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b678a8ff-34f4-19b2-72b1-5b35b75e8194@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=carlos@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=mg@max.gautier.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).