From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bird.elm.relay.mailchannels.net (bird.elm.relay.mailchannels.net [23.83.212.17]) by sourceware.org (Postfix) with ESMTPS id 139153851C36 for ; Thu, 20 Aug 2020 18:11:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 139153851C36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A018464174E; Thu, 20 Aug 2020 18:11:40 +0000 (UTC) Received: from pdx1-sub0-mail-a2.g.dreamhost.com (100-96-19-54.trex.outbound.svc.cluster.local [100.96.19.54]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D9404640B92; Thu, 20 Aug 2020 18:11:39 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a2.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.8); Thu, 20 Aug 2020 18:11:40 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Whimsical-Cellar: 5b525fa6117cb528_1597947100321_3843810161 X-MC-Loop-Signature: 1597947100321:3568428605 X-MC-Ingress-Time: 1597947100321 Received: from pdx1-sub0-mail-a2.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTP id 7FC487E78B; Thu, 20 Aug 2020 11:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=OPJhsy EIBt1wtqKi1/TbWL4yQkk=; b=lc0bb5H63b6EpC5hnhue3j+N/fz67ezkpXsUd1 gL0xj641Bb4kMyKDCDlX+sgSTPZoraIcs69KF+/4LPNF/VdwzAkwi02LZMGSO2FU x6VBIJCQkQRMWnnN0K2TzDlg+mPCXLBRM3G1rM/wVJl5GjejaKGUcBjffK4V9rhf GqNUg= Received: from [192.168.1.97] (unknown [123.252.202.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a2.g.dreamhost.com (Postfix) with ESMTPSA id E70717E789; Thu, 20 Aug 2020 11:11:35 -0700 (PDT) Subject: Re: Contribution Checklist - ChangeLog To: Carlos O'Donell , Florian Weimer Cc: Max Gautier , GLIBC Devel References: <20200819154837.GA182209@ol-mgautier.localdomain> <87k0xud3y7.fsf@mid.deneb.enyo.de> <20200819162227.GA183107@ol-mgautier.localdomain> <877dttbvim.fsf@mid.deneb.enyo.de> <1138b3e2-51a7-440a-6c2c-55e817de4f44@gotplt.org> <79ea0c20-0cf3-5c25-579d-67b0200959c0@gotplt.org> <270e209a-a0b9-1ca2-55c5-3eac44090d5d@redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a2 From: Siddhesh Poyarekar Message-ID: Date: Thu, 20 Aug 2020 23:41:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <270e209a-a0b9-1ca2-55c5-3eac44090d5d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduiedruddutddgjedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomhepufhiugguhhgvshhhucfrohihrghrvghkrghruceoshhiugguhhgvshhhsehgohhtphhlthdrohhrgheqnecuggftrfgrthhtvghrnheptdekgeegtddukefhieegveektedujeeghfdtgedvveeivefhgfektdelhfefvddvnecuffhomhgrihhnpehsohhurhgtvgifrghrvgdrohhrghenucfkphepuddvfedrvdehvddrvddtvddrudejvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopegludelvddrudeikedruddrleejngdpihhnvghtpeduvdefrddvhedvrddvtddvrddujedvpdhrvghtuhhrnhdqphgrthhhpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqedpmhgrihhlfhhrohhmpehsihguughhvghshhesghhothhplhhtrdhorhhgpdhnrhgtphhtthhopegtrghrlhhoshesrhgvughhrghtrdgtohhm X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2020 18:11:45 -0000 On 20/08/20 23:33, Carlos O'Donell wrote: > I would *love* v2 of the checklist to become *live* ... are you going to: > > (a) Edit v1 with the ChangeLog changes. > > or > > (b) Edit v2 and propose we use that. I just went through v2 now; looks like you wrote it early last year (and you made it exactly how I think it ought to be!) and I updated it for ChangeLog and left it at that. I propose we overwrite v1 with this. I've just edited it to completely drop any mention of a ChangeLog; if you think this looks good I'll overwrite the old checklist with it: https://sourceware.org/glibc/wiki/Contribution%20checklist%20v2 > My opinion is that backports to stable branches should *not* update the > ChangeLog. > > The ChangeLog is only valid at the time a tarball is created. > > If a stable branch has a release then the VCS update scripts will be used > to update the ChangeLog. That's a reasonable constraint. In that case it probably makes sense to drop mention of ChangeLog in legacy contributions too: https://sourceware.org/glibc/wiki/Legacy%20Contributions Siddhesh