From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 60FD03858012 for ; Thu, 1 Apr 2021 12:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60FD03858012 Received: by mail-qt1-x82d.google.com with SMTP id h7so1339992qtx.3 for ; Thu, 01 Apr 2021 05:45:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZdYGq9gYV8LOOL78F6rGz0drnk91mjssOu7rYP/TyBU=; b=kAEngDdnHWENmXwSuubmhUjl1NADAler3g+mzttb8/5JbeQQbxjJDpOkXqPuoQy+IG VFRRid7RPdHkrb+6JwjxX5xFChH0McCHM2Aptki51Qr24iTolrUd7WdYNx9MV7pSp8GE ekBqyepFWQ+7anpymJDQkfgtPArv00RkxOCgSO4yyJ/lZUox0oW9FMNjV41Pe/Wnmnzb osXiaqZfK6iGIu5dYb1/q6LwxfT++/LX5tptb870Uh27uvf6Nbrk7O1I3ovr2BAZ1tYw 31jF9NIV+/3DH7xN0FMDxKBZB+xiw+sWn1xdD+RS5/Cmu3EnYbxzffL1iXELuGMR2V1i wNvg== X-Gm-Message-State: AOAM530US+KD8dK4h6Cyp84WxNAHY2j4RjM+3vDYAop0Au8262F/bB0z kWBxrgHs8/k4SN3uzwnuc6ratZdYX2B1Ow== X-Google-Smtp-Source: ABdhPJyAvdKByTchI20iSmcs5VBVQ42q9V8cPXrvCD4HfeybeNNd6RFP5PxEQwotWXIik3a9hjT7lg== X-Received: by 2002:a05:622a:15cb:: with SMTP id d11mr6995436qty.230.1617281133570; Thu, 01 Apr 2021 05:45:33 -0700 (PDT) Received: from ?IPv6:2804:14c:485:832:3367:c887:263:9cc2? ([2804:14c:485:832:3367:c887:263:9cc2]) by smtp.gmail.com with ESMTPSA id a14sm3951480qkc.47.2021.04.01.05.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 05:45:33 -0700 (PDT) Subject: Re: [PATCH 3/5] linux: Use statx for MIPSn64 To: "Maciej W. Rozycki" Cc: libc-alpha@sourceware.org References: <20210319183121.2252064-1-adhemerval.zanella@linaro.org> <20210319183121.2252064-4-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: Date: Thu, 1 Apr 2021 09:45:31 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 12:45:37 -0000 On 31/03/2021 21:07, Maciej W. Rozycki wrote: > On Fri, 19 Mar 2021, Adhemerval Zanella via Libc-alpha wrote: > >> diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c >> index c3a030af58..b9b8cd994b 100644 >> --- a/sysdeps/unix/sysv/linux/fstatat64.c >> +++ b/sysdeps/unix/sysv/linux/fstatat64.c >> @@ -117,7 +137,8 @@ fstatat64_time64_stat (int fd, const char *file, struct __stat64_t64 *buf, >> } >> >> #if (__WORDSIZE == 32 \ >> - && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) >> + && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \ >> + || defined STAT_HAS_TIME32 > > Weird indentation here (which made me wonder how the ordering between && > and || has been resolved so that GCC does not complain before I realised > it's simply misindented parenthesisation). Only caught as I saw the GIT > commit message though. The preprocessor indentation is confusing sometimes, but I think it should adjusted only slight to follow other usages: diff --git a/sysdeps/unix/sysv/linux/fstatat64.c b/sysdeps/unix/sysv/linux/fstatat64.c index f968e4ef05..ab25f64187 100644 --- a/sysdeps/unix/sysv/linux/fstatat64.c +++ b/sysdeps/unix/sysv/linux/fstatat64.c @@ -137,7 +137,7 @@ fstatat64_time64_stat (int fd, const char *file, struct __stat64_t64 *buf, #if (__WORDSIZE == 32 \ && (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32)) \ - || defined STAT_HAS_TIME32 + || defined STAT_HAS_TIME32 # define FSTATAT_USE_STATX 1 #else Am I missing something here?