From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 320B23856DE7 for ; Fri, 15 Apr 2022 01:28:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 320B23856DE7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxusxFylhibskjAA--.45128S3; Fri, 15 Apr 2022 09:28:38 +0800 (CST) From: caiyinyu Subject: Re: [PATCH v2 07/14] LoongArch: Atomic and Locking Routines To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: xuchenghua@loongson.cn References: <20211231064455.1030051-1-caiyinyu@loongson.cn> <20211231064455.1030051-8-caiyinyu@loongson.cn> Message-ID: Date: Fri, 15 Apr 2022 09:28:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9AxusxFylhibskjAA--.45128S3 X-Coremail-Antispam: 1UD129KBjvJXoW3Jw1DWw1xZFyfZr43Wry5CFg_yoWxuF48pF W5CF4DGr4xWw47K3s2g3W3W3Z3tr10yF1Y9Fyagr48ArZ8A348WrsFkas8WFyxXr1fCryY vrs8Za47uan3JaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxV WxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl Yx0E2Ix0cI8IcVAFwI0_Jw0_WrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7I2V7IY0VAS07Al zVAYIcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_JFI_Gr1lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUCVW8JwCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73Uj IFyTuYvjfU5ksqDUUUU X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2022 01:28:43 -0000 在 2022/1/4 下午10:09, Adhemerval Zanella 写道: > On 31/12/2021 03:44, caiyinyu wrote: >> This patch implements various atomic and locking routines on LoongArch. >> --- >> .../loongarch/nptl/bits/pthreadtypes-arch.h | 41 ++++ >> sysdeps/loongarch/nptl/bits/semaphore.h | 32 +++ >> sysdeps/loongarch/nptl/libc-lowlevellock.c | 8 + >> .../sysv/linux/loongarch/atomic-machine.h | 196 ++++++++++++++++++ >> 4 files changed, 277 insertions(+) >> create mode 100644 sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h >> create mode 100644 sysdeps/loongarch/nptl/bits/semaphore.h >> create mode 100644 sysdeps/loongarch/nptl/libc-lowlevellock.c >> create mode 100644 sysdeps/unix/sysv/linux/loongarch/atomic-machine.h >> >> diff --git a/sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h b/sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h >> new file mode 100644 >> index 0000000000..e57f122a98 >> --- /dev/null >> +++ b/sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h >> @@ -0,0 +1,41 @@ >> +/* Machine-specific pthread type layouts. >> + Copyright (C) 2021 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library. If not, see >> +. */ >> + >> +#ifndef _BITS_PTHREADTYPES_ARCH_H >> +#define _BITS_PTHREADTYPES_ARCH_H 1 >> + >> +#include >> + >> +#ifdef __loongarch_lp64 >> +#define __SIZEOF_PTHREAD_ATTR_T 56 >> +#define __SIZEOF_PTHREAD_MUTEX_T 40 >> +#define __SIZEOF_PTHREAD_MUTEXATTR_T 4 >> +#define __SIZEOF_PTHREAD_COND_T 48 >> +#define __SIZEOF_PTHREAD_CONDATTR_T 4 >> +#define __SIZEOF_PTHREAD_RWLOCK_T 56 >> +#define __SIZEOF_PTHREAD_RWLOCKATTR_T 8 >> +#define __SIZEOF_PTHREAD_BARRIER_T 32 >> +#define __SIZEOF_PTHREAD_BARRIERATTR_T 4 >> +#else >> +#error "32bit LoongArch systems are not supported" >> +#endif >> + >> +#define __LOCK_ALIGNMENT >> +#define __ONCE_ALIGNMENT >> + >> +#endif /* bits/pthreadtypes.h */ > Why can't you use the generic definition? Also, I think all the __loongarch_lp64 > tests to avoid 32-bit build should be moved to a configure test instead. Fixed by using generic definition and __loongarch_lp64 tests have been moved to configure test. >> diff --git a/sysdeps/loongarch/nptl/bits/semaphore.h b/sysdeps/loongarch/nptl/bits/semaphore.h >> new file mode 100644 >> index 0000000000..510f3b0e9a >> --- /dev/null >> +++ b/sysdeps/loongarch/nptl/bits/semaphore.h >> @@ -0,0 +1,32 @@ >> +/* POSIX semaphore type layout >> + Copyright (C) 2021 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library. If not, see >> +. */ >> + >> +#ifndef _SEMAPHORE_H >> +#error "Never use directly; include instead." >> +#endif >> + >> +#define __SIZEOF_SEM_T (4 * __SIZEOF_POINTER__) >> + >> +/* Value returned if `sem_open' failed. */ >> +#define SEM_FAILED ((sem_t *) 0) >> + >> +typedef union >> +{ >> + char __size[__SIZEOF_SEM_T]; >> + long int __align; >> +} sem_t; > Why can't you use the generic linux header interface? Fixed by using generic linux header interface. >> diff --git a/sysdeps/loongarch/nptl/libc-lowlevellock.c b/sysdeps/loongarch/nptl/libc-lowlevellock.c >> new file mode 100644 >> index 0000000000..f4b8b5c193 >> --- /dev/null >> +++ b/sysdeps/loongarch/nptl/libc-lowlevellock.c >> @@ -0,0 +1,8 @@ >> +/* This kludge works around a libpthread static linking problem: >> +https://sourceware.org/bugzilla/show_bug.cgi?id=15648. */ >> + >> +#ifndef SHARED >> +#define __lll_lock_wait_private weak_function __lll_lock_wait_private >> +#endif >> + >> +#include > Why this file is required? Fixed by removing libc-lowlevellock.c >> diff --git a/sysdeps/unix/sysv/linux/loongarch/atomic-machine.h b/sysdeps/unix/sysv/linux/loongarch/atomic-machine.h >> new file mode 100644 >> index 0000000000..dbae608ee5 >> --- /dev/null >> +++ b/sysdeps/unix/sysv/linux/loongarch/atomic-machine.h >> @@ -0,0 +1,196 @@ >> +/* Atomic operations. >> + Copyright (C) 2021 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library. If not, see >> +. */ >> + >> +#ifndef _LINUX_LOONGARCH_BITS_ATOMIC_H >> +#define _LINUX_LOONGARCH_BITS_ATOMIC_H 1 >> + >> +#include >> + >> +typedef int32_t atomic32_t; >> +typedef uint32_t uatomic32_t; >> + >> +typedef int64_t atomic64_t; >> +typedef uint64_t uatomic64_t; >> + >> +typedef intptr_t atomicptr_t; >> +typedef uintptr_t uatomicptr_t; >> +typedef intmax_t atomic_max_t; >> +typedef uintmax_t uatomic_max_t; > These definition are not required any longer. Fixed. >> + >> +#define atomic_full_barrier() __sync_synchronize () >> + >> +#ifdef __LP64__ >> +#define __HAVE_64B_ATOMICS 1 >> +#endif > I think there is no need to guard it for __LP64__. Fixed.