From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6ACFA3858D3C for ; Tue, 17 May 2022 15:57:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6ACFA3858D3C Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-FJaQGUOdPxmN6iehMw_5eQ-1; Tue, 17 May 2022 11:57:57 -0400 X-MC-Unique: FJaQGUOdPxmN6iehMw_5eQ-1 Received: by mail-qv1-f70.google.com with SMTP id r13-20020a056214068d00b00461d27bf0fdso4292927qvz.1 for ; Tue, 17 May 2022 08:57:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=tgfFbo4dEaOy5s5SznuSxB47xIIUXiBUnXqrt/fqHw0=; b=TXl8NVxJZkhYtWnMFrvNZAiZMHmVayrkMgSUWACw/ti7NgV0rCqHlMJO6CSwrwX+Gz xwz6m9aoE7O8UOmssxcWsbH1jgjrA/FoUI1Drxp6oPMXr4e1vrKz/MwDpMiEfGcoOFEL HDuYBViwi9CZR71uJz/L4STpgdZAFvtbNY6vc3xhZpcLrlf1ggI01WURc4TGo9YzwDjK xhp8TQVTobv5xCG9mdd0HIridxlAY5eCFqpSbGaaypdxxsSIg62c2+9ony3KDS8wE0KJ Pv9Vo533Xui1HXDNLBmdgWeYlHd3LnwVLeB6ewgAvcEDHP5yhF1qx6isHm2scp46pK0I v5/w== X-Gm-Message-State: AOAM532V1GJGpBRaR9f0U5Upuyf9wusUgaj1YkFe68bJlBuMktyw1Ao6 +CiiWY3dX56VX1iZCj/5wtjjrtTT4x5yXoJmE2MxXz7wBXVXL5OUA7rv7GJ8mm1eUfCJoC8tmWr aVVEjY5PzBwCxbORE6Fiw X-Received: by 2002:ad4:4b65:0:b0:456:4582:597c with SMTP id m5-20020ad44b65000000b004564582597cmr20587046qvx.33.1652803076071; Tue, 17 May 2022 08:57:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi8jAqjXTat/r11povK2ADH6jgvhcZbl+5S/tcZgKPu4Oanvcy7vpYZWjTwWerZiNCoP/s9w== X-Received: by 2002:ad4:4b65:0:b0:456:4582:597c with SMTP id m5-20020ad44b65000000b004564582597cmr20587031qvx.33.1652803075850; Tue, 17 May 2022 08:57:55 -0700 (PDT) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id o4-20020ac87c44000000b002f39b99f6basm8216278qtv.84.2022.05.17.08.57.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 08:57:55 -0700 (PDT) Message-ID: Date: Tue, 17 May 2022 11:57:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/3]: C++20 P0482R6 and C2X N2653: Implement mbrtoc8, c8rtomb, char8_t To: Tom Honermann , Joseph Myers Cc: libc-alpha References: <57610f50-dd95-fd32-1102-5f1cda440891@honermann.net> From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 15:57:59 -0000 On 2/28/22 22:40, Tom Honermann via Libc-alpha wrote: > > On 2/28/22 6:01 PM, Joseph Myers wrote: >> On Sun, 27 Feb 2022, Tom Honermann via Libc-alpha wrote: >> >>> This patch provides implementations for the mbrtoc8 and c8rtomb functions >>> adopted for C++20 via WG21 P0482R6 [1] and for C2X via WG14 N2653 [2]. It also >>> provides the char8_t typedef adopted for C2X via WG14 N2653 [2]. >>> >>> The mbrtoc8 and c8rtomb functions are declared in uchar.h in C2X mode or when >>> the _GNU_SOURCE macro or C++20 __cpp_char8_t feature test macro is defined. >>> >>> The char8_t typedef is declared in uchar.h in C2X mode or when the _GNU_SOURCE >>> macro is defined and the C++20 __cpp_char8_t feature test macro is not defined >>> (if __cpp_char8_t is defined, then char8_t is a builtin type). >> You should almost never have "defined __USE_GNU || ..." in header >> conditionals, because _GNU_SOURCE implies the other feature test macros. > > Ah, right. Thank you, a corrected patch is attached. Tom, Could you please repost a v2 with Joseph's change incorporated? Your subject is also a bit odd with a leading colon. My suggestion is to use git send-email to post the series with a cover-letter to the list. The cover-letter can explain anything that the commit message doesn't include. -- Cheers, Carlos.