public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: Joseph Myers <josmyers@redhat.com>,
	Florian Weimer <fweimer@redhat.com>,
	"H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v3 0/7] Fix some libm static issues
Date: Mon, 20 May 2024 13:31:35 -0300	[thread overview]
Message-ID: <b77c2d6f-b6b0-4fda-8b93-3e2e8fb062cc@linaro.org> (raw)
In-Reply-To: <20240402140644.2172819-1-adhemerval.zanella@linaro.org>

Ping on this serie (the 2/7 and 3/7 were already reviewed).

On 02/04/24 11:06, Adhemerval Zanella wrote:
> Some recent math optimizations removed some symbols from the static
> build and due to the limited static build check, along with
> --disable-shared being broken for some time [1], this issue has slipped
> some releases.
> 
> Although the fix is straightforward, I added an extra framework to
> enable static build for  math libraries using the generic type
> framework (which autogenerated the tests for all supported types using
> the C template files). I have not enabled it for all tests due to the
> required extra size constraint, this is done with a new define that
> can be used with make check (build-math-static-tests).
> 
> As an experiment, I enabled static build for all autogenerated math
> tests. This has uncovered some extra missing symbols on some ABIs, along
> with some issues with implementation used on static for some ABIs.  On
> x86_64/i686 it shows that the assembly optimizations for acos, log10,
> log2, and ldbl-96 y0/y1 show some issues:
> 
>   x86_64-linux-gnu$ grep ^FAIL math/subdir-tests.sum
>   FAIL: math/test-float64x-acos-static
>   FAIL: math/test-float64x-log10-static
>   FAIL: math/test-float64x-log2-static
>   FAIL: math/test-float64x-y0-static
>   FAIL: math/test-float64x-y1-static
>   FAIL: math/test-ldouble-acos-static
>   FAIL: math/test-ldouble-log10-static
>   FAIL: math/test-ldouble-log2-static
>   FAIL: math/test-ldouble-y0-static
>   FAIL: math/test-ldouble-y1-static
>   
>   i686-linux-gnu$ grep ^FAIL math/subdir-tests.sum
>   FAIL: math/test-double-atanh-static
>   FAIL: math/test-float-atanh-static
>   FAIL: math/test-float32-atanh-static
>   FAIL: math/test-float32x-atanh-static
>   FAIL: math/test-float64-atanh-static
>   FAIL: math/test-float64x-acos-static
>   FAIL: math/test-float64x-acosh-static
>   FAIL: math/test-float64x-atanh-static
>   FAIL: math/test-float64x-log10-static
>   FAIL: math/test-float64x-log2-static
>   FAIL: math/test-float64x-y0-static
>   FAIL: math/test-float64x-y1-static
>   FAIL: math/test-ldouble-acos-static
>   FAIL: math/test-ldouble-acosh-static
>   FAIL: math/test-ldouble-atanh-static
>   FAIL: math/test-ldouble-log10-static
>   FAIL: math/test-ldouble-log2-static
>   FAIL: math/test-ldouble-y0-static
>   FAIL: math/test-ldouble-y1-static
> 
> The powerpc64le also shows multiple issues with the static linking
> (using gcc 13.1):
> 
>   FAIL: math/test-float128-exp10-static
>   FAIL: math/test-float64x-exp10-static
>   FAIL: math/test-ibm128-acos-static
>   FAIL: math/test-ibm128-copysign-static
>   FAIL: math/test-ibm128-exp10-static
>   FAIL: math/test-ibm128-fmod-static
>   FAIL: math/test-ibm128-frexp-static
>   FAIL: math/test-ibm128-modf-static
>   [...]
> 
> I have not analyzed what is happening, but it might be due to the
> '-mabi=ibmlongdouble' along with how libgcc.a was built (I saw some
> issues on GCC bugzilla).
> 
> I also tested this patchset with build-math-static-tests=yes for all
> ABIs, and there is not more build failures.
> 
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=20845
> 
> Adhemerval Zanella (7):
>   math: Add support for auto static math tests
>   math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488)
>   math: Fix i386 and m68k exp10 on static build
>   math: Fix isnanf128 static build
>   math: Provided copysignf128 for static libm on alpha, s390, and
>     sparcv9
>   math: Provide frexpf128 for static libm on alpha, s390, and sparcv9
>   math: Provide modf128 for static libm on alpha, s390, and sparcv9
> 
>  Makeconfig                                  |   5 +
>  Makefile.help                               |   4 +
>  math/Makefile                               | 113 +++++++++++++++++++-
>  math/test-double-static.h                   |   1 +
>  math/test-float-static.h                    |   1 +
>  math/test-float128-static.h                 |   1 +
>  math/test-float32-static.h                  |   1 +
>  math/test-float32x-static.h                 |   1 +
>  math/test-float64-static.h                  |   1 +
>  math/test-float64x-static.h                 |   1 +
>  math/test-ibm128-static.h                   |   1 +
>  math/test-ldouble-static.h                  |   1 +
>  sysdeps/i386/fpu/w_exp10_compat.c           |   9 +-
>  sysdeps/i386/fpu/w_fmod_compat.c            |   7 +-
>  sysdeps/i386/fpu/w_fmodf_compat.c           |   7 +-
>  sysdeps/ieee754/float128/float128_private.h |   2 +-
>  sysdeps/ieee754/float128/s_isnanf128.c      |   4 +
>  sysdeps/ieee754/ldbl-64-128/s_copysignl.c   |   4 +-
>  sysdeps/ieee754/ldbl-64-128/s_frexpl.c      |   4 +-
>  sysdeps/ieee754/ldbl-64-128/s_modfl.c       |   4 +-
>  sysdeps/ieee754/ldbl-opt/s_ldexpl.c         |   4 +-
>  sysdeps/m68k/m680x0/fpu/w_exp10_compat.c    |   9 +-
>  sysdeps/m68k/m680x0/fpu/w_fmod_compat.c     |   5 +-
>  sysdeps/m68k/m680x0/fpu/w_fmodf_compat.c    |   7 +-
>  24 files changed, 170 insertions(+), 27 deletions(-)
>  create mode 100644 math/test-double-static.h
>  create mode 100644 math/test-float-static.h
>  create mode 100644 math/test-float128-static.h
>  create mode 100644 math/test-float32-static.h
>  create mode 100644 math/test-float32x-static.h
>  create mode 100644 math/test-float64-static.h
>  create mode 100644 math/test-float64x-static.h
>  create mode 100644 math/test-ibm128-static.h
>  create mode 100644 math/test-ldouble-static.h
> 

      parent reply	other threads:[~2024-05-20 16:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 14:06 Adhemerval Zanella
2024-04-02 14:06 ` [PATCH v3 1/7] math: Add support for auto static math tests Adhemerval Zanella
2024-05-20 16:48   ` H.J. Lu
2024-05-20 17:21     ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 2/7] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488) Adhemerval Zanella
2024-05-11  9:59   ` Aurelien Jarno
2024-05-21 12:40   ` H.J. Lu
2024-05-21 12:54     ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 3/7] math: Fix i386 and m68k exp10 on static build Adhemerval Zanella
2024-05-11  9:59   ` Aurelien Jarno
2024-05-21 12:48   ` H.J. Lu
2024-05-21 12:54     ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 4/7] math: Fix isnanf128 " Adhemerval Zanella
2024-05-20 16:51   ` H.J. Lu
2024-05-20 18:53     ` Adhemerval Zanella Netto
2024-05-20 21:34   ` H.J. Lu
2024-05-21 12:32     ` Adhemerval Zanella Netto
2024-05-21 12:36       ` H.J. Lu
2024-05-21 12:56         ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 5/7] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 Adhemerval Zanella
2024-05-20 16:55   ` H.J. Lu
2024-05-20 19:04     ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 6/7] math: Provide frexpf128 " Adhemerval Zanella
2024-05-20 16:57   ` H.J. Lu
2024-05-20 19:06     ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 7/7] math: Provide modf128 " Adhemerval Zanella
2024-05-20 16:59   ` H.J. Lu
2024-05-20 19:07     ` Adhemerval Zanella Netto
2024-05-21 15:40       ` H.J. Lu
2024-05-21 16:41         ` Adhemerval Zanella Netto
2024-05-20 16:31 ` Adhemerval Zanella Netto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b77c2d6f-b6b0-4fda-8b93-3e2e8fb062cc@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=josmyers@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).