From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 412F13857C53 for ; Tue, 18 Jan 2022 13:38:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 412F13857C53 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20ICSOgn021804 for ; Tue, 18 Jan 2022 13:38:50 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dnwjwtdgp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 18 Jan 2022 13:38:50 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 20IDHfLN025957 for ; Tue, 18 Jan 2022 13:38:49 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dnwjwtdfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jan 2022 13:38:49 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 20IDXTXv010710; Tue, 18 Jan 2022 13:38:47 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma01fra.de.ibm.com with ESMTP id 3dknw9bjw9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jan 2022 13:38:47 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 20IDci9m41222556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Jan 2022 13:38:45 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C6F10A4055; Tue, 18 Jan 2022 13:38:44 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A3C70A404D; Tue, 18 Jan 2022 13:38:44 +0000 (GMT) Received: from [9.145.72.212] (unknown [9.145.72.212]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 18 Jan 2022 13:38:44 +0000 (GMT) Message-ID: Date: Tue, 18 Jan 2022 14:38:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 7/7] s390x: Use in early HWCAP check Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <201e517c6a751bebe505af99e35a9f8643066f31.1642162312.git.fweimer@redhat.com> <81a3cde1-250e-b04a-0037-4fb7f363fd42@linux.ibm.com> <87czkpjjan.fsf@oldenburg.str.redhat.com> <87sftli2xw.fsf@oldenburg.str.redhat.com> From: Stefan Liebler In-Reply-To: <87sftli2xw.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: m0xdE7fHAr2y-QeSiieHTPUQlA-aw6tz X-Proofpoint-ORIG-GUID: -OE78uWeo2pzitF6wdIwOoZYOGLKDGLO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-18_03,2022-01-18_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 spamscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201180083 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 13:38:52 -0000 On 18/01/2022 14:33, Florian Weimer wrote: > * Stefan Liebler: > >> On 18/01/2022 13:54, Florian Weimer wrote: >>> * Stefan Liebler: >>> >>>> I'm not quite sure if all your patches are already committed. I've just >>>> give it a try with commit f8b765bec44e6c464a7eabf80e58c6851ca15ac3: >>>> >>>> - configure glibc with --with-rtld-early-cflags=-march=zEC12 and >>>> CFLAGS=-march=z15 on a z15. >>>> >>>> - Rebooted with novx-kernel-parameter => vector-related HWCAPs are >>>> disabled and executing vector-instructions leads to a crash >>>> >>>> - run a helloworld-program: crash due to vector-instruction in >>>> _dl_setup_hash, which is called in _dl_start_final before >>>> _dl_sysdep_start is called which runs dl_hwcap_check. >>>> >>>> I've checked the build-log and see that the following files are compiled >>>> with -march=zEC12: >>>> - dl-printf.c >>>> - ../sysdeps/unix/sysv/linux/dl-write.c >>>> - dl-tunables.c >>>> - ../sysdeps/unix/sysv/linux/dl-sysdep.c >>>> - rtld.c >>> >>> Sorry, I missed that requirement. >>> >>> Would you mind testing the attached patch? >>> >>> Thanks, >>> Florian >> >> Sure. Now it works fine and I get the expected: >> Fatal glibc error: CPU lacks VXRS_EXT2 support (z15 or later required) > > Thanks. Should I push it with your Reviewed-by: and Tested-by:? > > Florian > Yes, this if fine for me. I've had a look at the patch and it just extracted the _dl_setup_hash function into a new file which is then build with the rtld-early-cflags. Reviewed-by: Stefan Liebler Tested-by: Stefan Liebler