From: Florian Weimer <fweimer@redhat.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: Fix struct sigaltstack namespace (bug 21517)
Date: Tue, 13 Jun 2017 06:34:00 -0000 [thread overview]
Message-ID: <b8350c14-c334-05dc-d5d6-82e183b55678@redhat.com> (raw)
In-Reply-To: <CAMKF1sp6T0Tf6ySjDEjpB0Hkykfi11j76502FUKeEchpKf5J4Q@mail.gmail.com>
On 06/12/2017 11:15 PM, Khem Raj wrote:
> On Sat, Jun 3, 2017 at 8:55 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 05/25/2017 12:32 AM, Joseph Myers wrote:
>>> +* The stack_t type no longer has the name struct sigaltstack. This changes
>>> + the C++ name mangling for interfaces involving this type.
>>
>> I checked Fedora and we don't seem to have any ABI impact from this
>> change (no exported symbols matching /^_Z.*sigaltstack/), so this is
>> probably fine.
>
> I think gcc sanitizers will have issues since they are using
> the forward declaration of sigaltstack
>
> see
> https://github.com/gcc-mirror/gcc/blob/master/libsanitizer/sanitizer_common/sanitizer_linux.h#L22
There's already a bug for that:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81066
There is no ABI impact, so this is fixable.
Thanks,
Florian
prev parent reply other threads:[~2017-06-13 6:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 22:33 Joseph Myers
2017-06-01 11:37 ` Ping " Joseph Myers
2017-06-03 14:15 ` Zack Weinberg
2017-06-03 15:55 ` Florian Weimer
2017-06-12 21:15 ` Khem Raj
2017-06-13 6:34 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8350c14-c334-05dc-d5d6-82e183b55678@redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).