From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73678 invoked by alias); 13 Jun 2017 06:34:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 73522 invoked by uid 89); 13 Jun 2017 06:34:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C2A6A80465 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C2A6A80465 Subject: Re: Fix struct sigaltstack namespace (bug 21517) To: Khem Raj Cc: Joseph Myers , GNU C Library References: <19d1c0b9-3c46-61cc-d874-93a7c2d43195@redhat.com> From: Florian Weimer Message-ID: Date: Tue, 13 Jun 2017 06:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00500.txt.bz2 On 06/12/2017 11:15 PM, Khem Raj wrote: > On Sat, Jun 3, 2017 at 8:55 AM, Florian Weimer wrote: >> On 05/25/2017 12:32 AM, Joseph Myers wrote: >>> +* The stack_t type no longer has the name struct sigaltstack. This changes >>> + the C++ name mangling for interfaces involving this type. >> >> I checked Fedora and we don't seem to have any ABI impact from this >> change (no exported symbols matching /^_Z.*sigaltstack/), so this is >> probably fine. > > I think gcc sanitizers will have issues since they are using > the forward declaration of sigaltstack > > see > https://github.com/gcc-mirror/gcc/blob/master/libsanitizer/sanitizer_common/sanitizer_linux.h#L22 There's already a bug for that: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81066 There is no ABI impact, so this is fixable. Thanks, Florian