From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 903D13858D20 for ; Fri, 4 Feb 2022 19:59:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 903D13858D20 Received: by mail-oi1-x232.google.com with SMTP id r27so9779966oiw.4 for ; Fri, 04 Feb 2022 11:59:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YD0cMfG6fcNtjP9qG+xnG0xByYG3QS102dCbkQhJpMQ=; b=xURQJvoaVeWrm6++UsxOI+LtWEKGIVKQo9uxQ4HtskTegCceTWl5rmvhB9T+rNg+fj hX2reHD3PaXb02V7T8ViU6YrQPW9Rv0P1qJsX2Vr5Zb/71hZW8gEGfI5FmkSRVnMwtpz VM0tawKFHOsIep01pu/SBp22ny07bupB2UZIYdaymRjfGHN8hvboGdc/TEtLesMfz9Rk Bz02AqrK5yb2W+5y6Z9t/wKCL9VkH45y+XN5xPH5D3r2viEuRBIn5a/9XU5jrbl1DEKE /2vByWybjdkyPyC1Sj+DOjfBQZXpgyIU/6OvUZdmj08TAW2DJW8QzUg9+o7yFv8rszWe ir4Q== X-Gm-Message-State: AOAM5303C9ZaJUjbhVoP5TjJgmQ6NFgeZZuhk6h7NdJZtuZM7WeK08N4 jN10vdc1HxERAPG2vMTkY0HjxzPatWqC4w== X-Google-Smtp-Source: ABdhPJxXK0UNmsMCvDb9yhFFf/jC3WD/HDN0mf0gDyiNocDlnKvPyacpbq78ZteKRWflv4YsA8+BYg== X-Received: by 2002:a05:6808:190f:: with SMTP id bf15mr2223900oib.40.1644004772918; Fri, 04 Feb 2022 11:59:32 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:5d1d:7038:55b6:a222? ([2804:431:c7ca:709a:5d1d:7038:55b6:a222]) by smtp.gmail.com with ESMTPSA id n4sm1085693otq.63.2022.02.04.11.59.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 11:59:32 -0800 (PST) Message-ID: Date: Fri, 4 Feb 2022 16:59:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 01/15] linux: Add pidfd_open Content-Language: en-US To: Joseph Myers Cc: libc-alpha@sourceware.org References: <20220203174634.3474775-1-adhemerval.zanella@linaro.org> <20220203174634.3474775-2-adhemerval.zanella@linaro.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 19:59:35 -0000 On 04/02/2022 16:46, Joseph Myers wrote: > On Thu, 3 Feb 2022, Adhemerval Zanella via Libc-alpha wrote: > >> + sys.exit(glibcextract.compare_macro_consts( >> + '#include \n', >> + '#include \n' >> + '#include \n', >> + args.cc, >> + 'PIDFD_.*')) > > Are you sure about doing this sort of comparison without the kind of > kernel version checks done in tst-mman-consts.py? That's only OK if (a) > all the compared macros are present in the oldest kernel headers version > supported for building glibc and (b) no matching macros will be added in > any future kernel version. > Right, I think it would be good to add such check since neither (a) or (b) might hold true.