From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2f.google.com (mail-oa1-x2f.google.com [IPv6:2001:4860:4864:20::2f]) by sourceware.org (Postfix) with ESMTPS id F2BCC3858D32 for ; Fri, 7 Apr 2023 18:19:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2BCC3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-177b78067ffso46450565fac.7 for ; Fri, 07 Apr 2023 11:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680891579; x=1683483579; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hxmug2mFye6IL5I3rMhFMM8ysNtL4w/jDoj06g8G0nM=; b=h0ggO2WXqBeycebiudTuYi+O4OS4ox9qfIYOrbJQ3VCBLrUobhgKZJaZHr3Yckvewt oAA6+c09SJhVHLTF8mGJRrn6FIXxPo+u/GFuLRugGKYF4t4DQeSirryN1mQ66ST3VM3o RyQ9jq/Ij6yg+2tNmCWD559ks8T2DVpGemKCqR8iLQb51LAFFKmdVUjMmcbCnUzfws0Q 3hEB36Bs7ANwcOdzq+Z/4dQrkNoTu7L6xydaRs78l5wTv3M12U1XAI5k7nMdEpA8T8V7 llY5ZxeS954/4Qz3Q+FqdwQsNZ1TwT2PWI9XDTjdLFxokLRxZD0t1GpSWxKDXFpantaX cx8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680891579; x=1683483579; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hxmug2mFye6IL5I3rMhFMM8ysNtL4w/jDoj06g8G0nM=; b=Z7suRSnGFfqOhurleMyd3kpSkDWPiviGu0iy6b25aVnIJ22+HgndjzFzUpA1Ia0o8U aLUnfesJr1iZRpvxaM2B3rqkqTZw+6zJu0lKHXbGtKkP4UJzZM72q57Ee0ioA3y4KPR3 BuqHNTmMQegi+fx26J2y0dpPEYGwp6V3iTuq4K+jfelNo2tpEo7GrRB9e35IkghlOIdd yS/E+sYuzCKso412fUZpbD2AMa8Ri3RG2TFxdt2V7SAnuyJ4LQu7WQd1uMo3sW0eNzh7 n2L7hG7Ci9l/nSdNN0EruU5PcUwDn9Tl4U4oW2VC9EC2krj2GCLhsZVEzrcUERls9L08 0qrg== X-Gm-Message-State: AAQBX9ciyjVHUlRSnz19kUEdyqfOIz0GEYdE3zwzp+jbBB64y84Qlxel gCVU/Jk055LkqXsr4vkz6RueMA== X-Google-Smtp-Source: AKy350aDcab6vHNNC5tDRQVrqBZWkrNJyuPZYLZacT2CIhd4xdVUVq5xtMJsjtDtlcgSjYbD90vPKA== X-Received: by 2002:a05:6870:588c:b0:180:219d:e7fc with SMTP id be12-20020a056870588c00b00180219de7fcmr1993826oab.13.1680891578974; Fri, 07 Apr 2023 11:19:38 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:e5a5:c0c1:f69:cfce:1b3? ([2804:1b3:a7c1:e5a5:c0c1:f69:cfce:1b3]) by smtp.gmail.com with ESMTPSA id vk2-20020a0568710e4200b0017e0c13b29asm1796520oab.36.2023.04.07.11.19.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 11:19:38 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 15:19:36 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 1/3] string: Allow use of test-string.h for non-ifunc implementations. Content-Language: en-US To: Joe Simmons-Talbott , libc-alpha@sourceware.org References: <20230329150500.2886135-1-josimmon@redhat.com> <20230404190040.2507343-1-josimmon@redhat.com> <20230404190040.2507343-2-josimmon@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230404190040.2507343-2-josimmon@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04/04/23 16:00, Joe Simmons-Talbott via Libc-alpha wrote: > Mark two variables as unused to silence warning when using > test-string.h for non-ifunc implemenations. s/implemenations/implementations LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > string/test-string.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/string/test-string.h b/string/test-string.h > index 41de973479..8bcb8afd0a 100644 > --- a/string/test-string.h > +++ b/string/test-string.h > @@ -130,8 +130,8 @@ cmdline_process_function (int c) > /* Increase size of FUNC_LIST if assert is triggered at run-time. */ > static struct libc_ifunc_impl func_list[32]; > static int func_count; > -static int impl_count = -1; > -static impl_t *impl_array; > +static int impl_count __attribute__ ((unused)) = -1; > +static impl_t *impl_array __attribute__ ((unused)); > > # define FOR_EACH_IMPL(impl, notall) \ > impl_t *impl; \