Re: [PATCHv3 1/4] ldbl-128: Rename 'long double' to '_Float128'

["Paul E. Murphy" <murphyp@linux.vnet.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]



On 08/31/2016 12:02 PM, Joseph Myers wrote:
> On Wed, 31 Aug 2016, Paul E. Murphy wrote:
> 
>> On 08/30/2016 12:16 PM, Joseph Myers wrote:
>>> On Tue, 30 Aug 2016, Paul E. Murphy wrote:
>>>
>>>> Is there any objection to committing patches 1 and
>>>> 2 once approved?
>>>
>>> I don't intend to review patch 2 until patch 1 is in.
>>>
>>
>> For my clarity, is the revised v3 patch 1 OK for commit?
> 
> Yes, given a followup to fix indentation in cases where we have
> 
> long double var = (expression
> 		   continued);
> 
> and so changing long double to _Float128 requires the following lines in 
> the continued expression to be reindented (that appears twice in 
> e_gammal_r.c, at least).

Attached is a patch to cleanup e_gammal_r.c.  I didn't come
across any others.  OK too?


[-- Attachment #2: 0001-ldbl-128-Cleanup-e_gammal_r.c-after-_Float128-rename.patch --]
[-- Type: text/x-patch, Size: 1696 bytes --]

From 25113f286be4ac32a124404b178f244c9508c954 Mon Sep 17 00:00:00 2001
From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
Date: Wed, 31 Aug 2016 13:17:35 -0500
Subject: [PATCH] ldbl-128: Cleanup e_gammal_r.c after _Float128 rename

	* sysdeps/ieee754/ldbl-128/e_gammal_r.c:
	(gammal_positive): Fix spacing.
	(__ieee754_gammal_r): Likewise.
---
 sysdeps/ieee754/ldbl-128/e_gammal_r.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sysdeps/ieee754/ldbl-128/e_gammal_r.c b/sysdeps/ieee754/ldbl-128/e_gammal_r.c
index 43282fe..ac68b31 100644
--- a/sysdeps/ieee754/ldbl-128/e_gammal_r.c
+++ b/sysdeps/ieee754/ldbl-128/e_gammal_r.c
@@ -105,10 +105,10 @@ gammal_positive (_Float128 x, int *exp2_adj)
 	}
       *exp2_adj = x_adj_log2 * (int) x_adj_int;
       _Float128 ret = (__ieee754_powl (x_adj_mant, x_adj)
-			 * __ieee754_exp2l (x_adj_log2 * x_adj_frac)
-			 * __ieee754_expl (-x_adj)
-			 * __ieee754_sqrtl (2 * M_PIl / x_adj)
-			 / prod);
+		       * __ieee754_exp2l (x_adj_log2 * x_adj_frac)
+		       * __ieee754_expl (-x_adj)
+		       * __ieee754_sqrtl (2 * M_PIl / x_adj)
+		       / prod);
       exp_adj += x_eps * __ieee754_logl (x_adj);
       _Float128 bsum = gamma_coeff[NCOEFF - 1];
       _Float128 x_adj2 = x_adj * x_adj;
@@ -188,8 +188,8 @@ __ieee754_gammal_r (_Float128 x, int *signgamp)
 	      if (frac > 0.5L)
 		frac = 1.0L - frac;
 	      _Float128 sinpix = (frac <= 0.25L
-				    ? __sinl (M_PIl * frac)
-				    : __cosl (M_PIl * (0.5L - frac)));
+				  ? __sinl (M_PIl * frac)
+				  : __cosl (M_PIl * (0.5L - frac)));
 	      int exp2_adj;
 	      ret = M_PIl / (-x * sinpix
 			     * gammal_positive (-x, &exp2_adj));
-- 
2.4.11