From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id C57D8385800C for ; Mon, 8 Nov 2021 18:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C57D8385800C Received: by mail-oi1-x22c.google.com with SMTP id u2so29093824oiu.12 for ; Mon, 08 Nov 2021 10:56:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xLKPgbVBhwdeNqHNshUpLQ7gA+SdNt801qyNBUOlyWY=; b=i2uX/cOtwHyHKFRSLH+9RDEuFTlDQXDNtnWWHWRX8BPSAWloxViSvPkCVtYaTdiqRB Wr/azClApNwwe9XQ0vHlILcukFnSPa6uQEzFkAEaJyKyCkIhdbSGsmwyHfr42vVnQXGg DvYOOzpkQ0W23tU9Ui6Vvd2hwayL+fUGXegadaQUwYgU2QumEKY6pc0UWa5L8FVu1HHj 59GPG7+oSxjUWTgKS90eB4zQEReMuYSe5M0lj6UQgDezZtkdbowx3uw5o1zMB5RnBqYy Mzx5DAloFLgxebv/t+IA8k07d83IBRVp0Q+fVX2S7InggTL+lfqlD0ZX9gRtKTNieYqp LFVA== X-Gm-Message-State: AOAM5318FY82/SLZL1DE3VD1QXyqCvGvai3N3oQ18kULl76Sfy0eLwbp LqIGNLu0nvShkDG6wxvt54aOVw== X-Google-Smtp-Source: ABdhPJx9OktQp1D2to8GfC6WwnrFK64sKHMARM+uUSVetMrYsXTYel0c4/ylXyGXYtYCdc0ByL4noQ== X-Received: by 2002:a05:6808:e90:: with SMTP id k16mr431273oil.166.1636397768157; Mon, 08 Nov 2021 10:56:08 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:c067:29b:4c08:be99? ([2804:431:c7cb:55a:c067:29b:4c08:be99]) by smtp.gmail.com with ESMTPSA id o2sm6420848otl.34.2021.11.08.10.56.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 10:56:07 -0800 (PST) Message-ID: Date: Mon, 8 Nov 2021 15:56:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] ci: Check for necessary Debian packages when running build-many-glibcs.py Content-Language: en-US To: Florian Weimer , Lukasz Majewski Cc: Joseph Myers , Carlos O'Donell , Andreas Schwab , "libc-alpha@sourceware.org" References: <20211108165255.15600-1-lukma@denx.de> <87bl2uh8i1.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87bl2uh8i1.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 18:56:12 -0000 On 08/11/2021 14:17, Florian Weimer wrote: > * Lukasz Majewski: > >> The build-many-glibc.py can be run on a 'vanila' Debian distribution >> (as for example in docker container), which don't have by default >> installed some packages (like flex). >> >> This causes build break at late stage of the full build; >> ../src/scripts/build-many-glibcs.py . checkout --replace-sources && >> ../src/scripts/build-many-glibcs.py . host-libraries && >> ../src/scripts/build-many-glibcs.py . compilers && >> ../src/scripts/build-many-glibcs.py . glibcs >> >> To avoid such situation, this check has been added to inform user >> early of required (and missing) Debian packages. >> >> The same approach (with using the 'distro' python module) can be >> applied to Fedora or Suse. > > I would recommend searching for required tools on PATH, using > shutil.which. This should work on any distribution. If I recall > correctly, the non-obvious tools are: > > bison > flex > git > makeinfo > patch > tar I think we might need gunzip, bunzip2, and unxz as well.