From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id 7170C385D0DF for ; Mon, 31 Oct 2022 17:25:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7170C385D0DF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-13bd2aea61bso14243818fac.0 for ; Mon, 31 Oct 2022 10:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=K7ohR7DYS4M+gEnTCZNd6H20Jf+1hGrMOd/ItK75RYc=; b=k+gftFx+hCvw61DoLuiNrfAtIBedsLrxo6SBoerf+D2Bws02w4Y4E/TXGH1bFiA6Hr Z6twq3a7bpNWA5cHX25CrgSHVNOmT6e54vmTyUtWae2eL0Xgn/INsYqJNNjR6qIe4QOg pe0GoVLl2F/ESAa0pytshMZdsVwQpBXw6HQM21Kf8txRFywdELBQNA9iCLs0Lr884jPn 0+gAMOzm23T+KvkDG9BXfRF/vcJoI26Cd007hQUxBM6+smkwyL1IAsYB/Blj8C3+NKeJ DAK5ZqQBXfevby6zT4NP7VvNwKu+s7W2/cPGxuzvHsarX9EVLJJfX0C4VfziOYiEgRgM e7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K7ohR7DYS4M+gEnTCZNd6H20Jf+1hGrMOd/ItK75RYc=; b=Pt3yKDILf5y/cpJvQN92oZWi/zOIzjY4eu255+4avlj88Jel9L9zSwhaQ/y1PWta09 usxi61AiyVywMdU/JqcRBbFzQ3jo0m3eCl5cyxARX5K2ClBbfDFHTq2bMW8Pn8Arhwwk xqAGEhqRE4fQ9rCPJlBbTuNZxwDV35ABKUNoKd2hhp1dNd1pCEgxdH1fSgHKZ/lLgIDC puVL5w//zdSX/C5kceuz3kacLIfUlk/VPuMDygmFSOssI0cRpgGJEIB+D7itntHnFyEg Spp7xWNDLAZUsbhQ5durn17YssCRs8fNLb3I79VRvQMJB0o97EUPVNCIzCJ5UYtIcfBv pclQ== X-Gm-Message-State: ACrzQf0KNguFZo/Mvq2DNYiOolYJxZjsdz9SRVysXnHzInuxetln84y5 Ka/aadmiAmRlceDIMm2h0oQ0BBgxzEJVdD6B X-Google-Smtp-Source: AMsMyM5vGUW6r4c0BfknJuOfYQ9JSnxaDt2YsVEgm5hKEpChWPbo0vovr8/dKUOGHl4ZD5wLbbItSA== X-Received: by 2002:a05:6871:5c8:b0:13b:716f:97b4 with SMTP id v8-20020a05687105c800b0013b716f97b4mr8154154oan.178.1667237115683; Mon, 31 Oct 2022 10:25:15 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1? ([2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1]) by smtp.gmail.com with ESMTPSA id d94-20020a9d2967000000b0066b9a6bf3bcsm2960563otb.12.2022.10.31.10.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 10:25:15 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 14:25:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] linux: Fix fstatat with !XSTAT_IS_XSTAT64 and __TIMESIZE=64 (BZ #29730) Content-Language: en-US From: Adhemerval Zanella Netto To: Aurelien Jarno , libc-alpha@sourceware.org References: <20221028205440.1091298-1-aurelien@aurel32.net> <85bbb5fa-735e-254e-4467-e2726fd0ecc3@linaro.org> Organization: Linaro In-Reply-To: <85bbb5fa-735e-254e-4467-e2726fd0ecc3@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31/10/22 13:03, Adhemerval Zanella Netto wrote: > > > On 28/10/22 17:54, Aurelien Jarno wrote: >> Commit 6e8a0aac2f883 ("time: Fix overflow itimer tests on 32-bit >> systems") changed in_time_t_range to assume a 32-bit time_t. Therefore >> stop calling it from __fstatat for systems with 64-bit time_t. >> >> Resolves: BZ #29730 > > Although this change is not incorrect, I think the fix I just sent [1] is > slight better because it just alias non-LFS stat to LFS stat for mips > (which is also a small runtime and code optimization), while avoiding > touching generic code (so we need to check if trigger another issue on > different architecture). > > [1] https://sourceware.org/pipermail/libc-alpha/2022-October/143089.html So I was wrong that we can assume stat and stat64 are equal on mips. Maybe instead of adding the fix on stat we can make it more generic and move it to is_time_t_range (so it can potentially fix usage not only on stat code) as my comment on https://sourceware.org/bugzilla/show_bug.cgi?id=29730 ?