From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 175893858D28 for ; Fri, 31 Mar 2023 13:37:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 175893858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-177ca271cb8so23187967fac.2 for ; Fri, 31 Mar 2023 06:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680269862; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=M8Pd8608betX0aOOTmPMqUH/2HPMY+Sead3ErV6Zun8=; b=ranxluuQ4Ek+gCkh3VIJugZiJusAf4opDcfIjhiolMQav/+tsoegb+URZS0QzQWvOG vr3G/SAGdU74akhYb3q7+mh1LWpjIZ7aX6hT5Z+2VOrT4rvA7smOl92uFtp5ZctHLtJ0 h4rnSwWG2oyUzBEqDfj1QNGdJ/IRMbPNMDHMdc0PTr82yf227WOT0gpYtg8b9Ob/IbfE 1QWcO7Iav/cda09Kw17GDW1GYgkC9vnaScy9lTekqEIbwdgODa9soq/2hiv4X1aD1TrC DzjDkf5WvJzzcsCKjp41bs66Kss4VDCe45S67LTRGcgJyS0jO6Zw7yJxTpToCBrioSN/ Wihg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680269862; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M8Pd8608betX0aOOTmPMqUH/2HPMY+Sead3ErV6Zun8=; b=KEpdj78bv1QVG6riJr66i1RoSrgc4pftVhYCEl+l+qL3dAsmdubP6YKqgBvWnlCZdP 5avYYQWT9gcdKELrLz9pGAHaZ6G/WI4QH8+juXtN1wTEnASmDIM7Nh/u/F7AkMseYeuD CD8gsHw22eYeYM/LaWyOSuO0SmDu72ifiG0Wzs/0yuy0SB/Jpbjfg8ornWviIxOfmvon zNMVRPxyQl/7PHAfVz6kdIPN7mCvjx3DKkw9JrCfTY9uzWDZ2FYKwiZ9cGLs0QCc/urH opHYfNuRY/9qRjvFnwjF7piB3YfKCjEgwMyZ1w9m0D76lim4nPqTh+rEMkzBD68r1osq Vf/Q== X-Gm-Message-State: AAQBX9fic45Hk9a+u4qH0XVCtYxcysxozQ7u+/vPT2LzuV21VUcIqZ28 ufhh8Sb6Bb1AQQVSXc7u2GdHzq4wWGzQbLLWnqI/pg== X-Google-Smtp-Source: AKy350ZiwIcQ/z48Vu95kzFmLH/M6q6OxZv1dc93hMU+R1Z83BWHpUZZGoEo9Lqf6xro0GPJi5WVug== X-Received: by 2002:a05:6870:82a8:b0:180:2a5e:7f8f with SMTP id q40-20020a05687082a800b001802a5e7f8fmr2627389oae.22.1680269862369; Fri, 31 Mar 2023 06:37:42 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:60f9:4ca7:df5c:ca4c:27b4? ([2804:1b3:a7c1:60f9:4ca7:df5c:ca4c:27b4]) by smtp.gmail.com with ESMTPSA id e8-20020a9d7308000000b006a11af03732sm1077994otk.67.2023.03.31.06.37.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 06:37:41 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 10:37:38 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: Ping: [PATCH] time: Fix strftime(3) API regarding nullability Content-Language: en-US To: Alejandro Colomar , libc-alpha@sourceware.org Cc: Alejandro Colomar , Paul Eggert References: <20230312000810.51652-1-alx@kernel.org> <70951a20-7444-0bd8-6e15-3fa1bcc28cb6@gmail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <70951a20-7444-0bd8-6e15-3fa1bcc28cb6@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Committed, thanks. On 30/03/23 20:43, Alejandro Colomar wrote: > Ping :) > > On 3/13/23 18:10, Adhemerval Zanella Netto wrote: >> >> >> On 11/03/23 21:08, Alejandro Colomar via Libc-alpha wrote: >>> strftime(3) doesn't accept null pointers in any of the parameters. >>> >>> Cc: Paul Eggert >>> Signed-off-by: Alejandro Colomar >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella >> >>> --- >>> time/time.h | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/time/time.h b/time/time.h >>> index d18089116e..28fb075b19 100644 >>> --- a/time/time.h >>> +++ b/time/time.h >>> @@ -99,7 +99,8 @@ extern time_t __REDIRECT_NTH (mktime, (struct tm *__tp), __mktime64); >>> of characters written, or 0 if it would exceed MAXSIZE. */ >>> extern size_t strftime (char *__restrict __s, size_t __maxsize, >>> const char *__restrict __format, >>> - const struct tm *__restrict __tp) __THROW; >>> + const struct tm *__restrict __tp) >>> + __THROW __nonnull((1, 3, 4)); >>> >>> #ifdef __USE_XOPEN >>> /* Parse S according to FORMAT and store binary time information in TP. >