From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 7D97C3858D38 for ; Wed, 2 Nov 2022 06:13:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D97C3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.187]) by gateway (Coremail) with SMTP id _____8DxvrdyCmJjoPIDAA--.9044S3; Wed, 02 Nov 2022 14:13:06 +0800 (CST) Received: from [10.20.4.187] (unknown [10.20.4.187]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxZ1dxCmJj_K4JAA--.11526S3; Wed, 02 Nov 2022 14:13:06 +0800 (CST) From: caiyinyu Subject: Re: [PATCH] LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1]. To: Xi Ruoyao , Carlos O'Donell , adhemerval.zanella@linaro.org Cc: i.swmail@xen0n.name, libc-alpha@sourceware.org References: <20221031034334.3027740-1-caiyinyu@loongson.cn> <0a618c5f8c1d5a621e157a6167048c102fd8d501.camel@xry111.site> <51360f07-4965-c6f7-8e30-160c8e6880f7@loongson.cn> Message-ID: Date: Wed, 2 Nov 2022 14:13:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxZ1dxCmJj_K4JAA--.11526S3 X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvJXoW7CryDXrW3Jr43tr15Cw1xZrb_yoW8urW8pr 18CF4UAryUtFn3GanYq3Z0kryUGr48A3yUGrW5uF48KasIy34qgw4jgF4SgFn8Zr4kZ3Z7 Z34kuwnFvFZrXrUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bI8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2 IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4U McvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487Mx AIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_ Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwI xGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8 JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcV C2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxU70PfDUUUU X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2022/11/1 上午10:14, Xi Ruoyao 写道: > On Tue, 2022-11-01 at 10:02 +0800, caiyinyu wrote: > >> diff --git a/elf/elf.h b/elf/elf.h >> >> index 3f08823a30..d51eb75a73 100644 >> --- a/elf/elf.h >> +++ b/elf/elf.h >> @@ -4093,8 +4093,11 @@ enum >>   #define R_NDS32_TLS_DESC       119 >> >>   /* LoongArch ELF Flags */ >> -#define EF_LARCH_ABI           0x07 >> -#define EF_LARCH_ABI_LP64D     0x03 >> +#define EF_LOONGARCH_ABI_MODIFIER_MASK 0x07 >> +#define EF_LOONGARCH_ABI_SOFT_FLOAT     0x01 >> +#define EF_LOONGARCH_ABI_SINGLE_FLOAT   0x02 >> +#define EF_LOONGARCH_ABI_DOUBLE_FLOAT   0x03 >> +#define EF_LOONGARCH_OBJABI_V1          0x40 > Again, is "LARCH" -> "LOONGARCH" change intentional? The ABI doc does > not specified the name of these macros... And we already have R_LARCH_* > so the difference of "LARCH" and "LOONGARCH" seems puzzling. We will use *LARCH* to keep consistent in glibc and binutils like other arches and update the docs soon: diff --git a/elf/elf.h b/elf/elf.h index d51eb75a73..04dc2ee563 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -4093,11 +4093,11 @@ enum  #define R_NDS32_TLS_DESC       119  /* LoongArch ELF Flags */ -#define EF_LOONGARCH_ABI_MODIFIER_MASK 0x07 -#define EF_LOONGARCH_ABI_SOFT_FLOAT     0x01 -#define EF_LOONGARCH_ABI_SINGLE_FLOAT   0x02 -#define EF_LOONGARCH_ABI_DOUBLE_FLOAT   0x03 -#define EF_LOONGARCH_OBJABI_V1          0x40 +#define EF_LARCH_ABI_MODIFIER_MASK  0x07 +#define EF_LARCH_ABI_SOFT_FLOAT     0x01 +#define EF_LARCH_ABI_SINGLE_FLOAT   0x02 +#define EF_LARCH_ABI_DOUBLE_FLOAT   0x03 +#define EF_LARCH_OBJABI_V1          0x40  /* LoongArch specific dynamic relocations */  #define R_LARCH_NONE           0 > And is it an option to keep old names there with a warning? > > #define EF_LARCH_ABI_LP64D __glibc_macro_warning ("EF_LARCH_ABI_LP64D is deprecated") 0x03 > I tend to remove it now.