From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] sparc: Fix .udiv plt on libc
Date: Mon, 27 Mar 2017 15:33:00 -0000 [thread overview]
Message-ID: <b9ce629d-29ce-70c0-bcb5-397b9bcc7caf@linaro.org> (raw)
In-Reply-To: <1078e264-e80b-114f-abe7-e81460153b9b@linaro.org>
On 16/03/2017 13:59, Adhemerval Zanella wrote:
>
>
> On 16/03/2017 11:45, Florian Weimer wrote:
>> On 03/16/2017 02:43 PM, Adhemerval Zanella wrote:
>>> To avoid it, this patch uses the linker option --wrap to replace all
>>> the internal libc.so .udiv calls to the wrapper __wrap_.udiv. Along
>>> with strong alias in the udiv implementations, it makes linker do
>>> local calls.
>>
>> I think we already use a different mechanism for a similar purpose, via sysdeps/generic/symbol-hacks.h. Maybe it's possible to reuse that?
>>
>> Thanks,
>> Florian
>
> The problem is now that divdi3 is not provided by glibc anymore we can't
> use the same trick since __divdi3 and __moddi3 will be provided by libgcc.
> Another way to actually redefine .udiv is to either still keep using divdi3
> for sparc32 .
>
Any more impeding remark about this patch?
next prev parent reply other threads:[~2017-03-27 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 13:43 [PATCH 1/2] Build divdi3 only for architecture that required it Adhemerval Zanella
2017-03-16 13:43 ` [PATCH 2/2] sparc: Fix .udiv plt on libc Adhemerval Zanella
2017-03-16 14:45 ` Florian Weimer
2017-03-16 16:59 ` Adhemerval Zanella
2017-03-27 15:33 ` Adhemerval Zanella [this message]
2017-03-16 13:58 ` [PATCH 1/2] Build divdi3 only for architecture that required it Andreas Schwab
2017-03-16 17:00 ` Adhemerval Zanella
[not found] ` <af83ffde-83d3-d7d1-d45e-7c379b7e7123@linaro.org>
2017-04-06 16:11 ` Adhemerval Zanella
2017-04-18 21:21 ` Joseph Myers
2017-04-18 22:29 ` Adhemerval Zanella
2017-04-19 21:01 ` Adhemerval Zanella
2017-05-10 13:24 ` Joseph Myers
2017-05-10 20:24 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ce629d-29ce-70c0-bcb5-397b9bcc7caf@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).