From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4D7E43854169 for ; Mon, 31 Oct 2022 13:12:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D7E43854169 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667221978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AglPpGEEqpG7IFlJZ9LOELZkz/8sGtmamBJ98yBgF8M=; b=AvphLosfxYluddR3yQaRsIIGpVinDhrY2P4d/Xng9yeifV8gIqV6BsIffP6xc2OX37O76r +XKtlUrF+4aoqxuEZnBqutNIFgpSs1No1EDwgpxmwPKbTD1nVePi5GLn7rN9rUXKm7EkGU ZFzoFExwa5n/DW6PskrxNLEMhaztrjs= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-152-rtNuGVH8Ow-Dai3wL_aF4w-1; Mon, 31 Oct 2022 09:12:55 -0400 X-MC-Unique: rtNuGVH8Ow-Dai3wL_aF4w-1 Received: by mail-io1-f70.google.com with SMTP id q17-20020a5d87d1000000b006d21a9cca67so495731ios.2 for ; Mon, 31 Oct 2022 06:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AglPpGEEqpG7IFlJZ9LOELZkz/8sGtmamBJ98yBgF8M=; b=GRnIKT9xw5B/CSBuaOMaplhwFJznl8PuTmVl0wA2pgGZrb1R+IOyvpm3U+ZI9zDt2s F6E+Ra8+D5AMLp92jvSzr7b3xXsw1l4e2jPDHKv9xDCfTy0KutqVXK9JG1hG/4gk2r0G adtgD1qSjdRS2lp+W1ldKLWM/WGPr6h52H+7rzmwMpDCLvVZra2TG/0Ut6Ngg3l1Il0c Skv4mHasTikbpR/PSj4HAi1mS/zry6XLy+xpK9if+mKkyJGAH5I4E1V04DUZ7Lio8AlW As5ECQ5M4FEjFSs/S02Ph9dWhLYwbOcsc6gHazUrmvuj/uLAgagveQ3KCXC7V4/Ghh+8 hkDA== X-Gm-Message-State: ACrzQf1pwPKYFXAtdon35c45xaRfVhInMAVFDZPA9EjZbjjv1epLmS0k BtHeTlv1Fo+KmG4iQuC3ZtnbjTkV9fXxjqqpvIv+/9FBcHWVgwKdiBLI+WdHSVaiaJvYRY9bNts nE5oFXPtp1y0g/IKD2+4O X-Received: by 2002:a6b:e219:0:b0:6c2:13ef:10a9 with SMTP id z25-20020a6be219000000b006c213ef10a9mr7106930ioc.6.1667221974906; Mon, 31 Oct 2022 06:12:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7xwhpXyTtdAI2u/K7jCiO/jBMFFKbFpFJFyi+vB1eVPrTp0NYJ3tujj7aGj0xWPWfxyPsMHA== X-Received: by 2002:a6b:e219:0:b0:6c2:13ef:10a9 with SMTP id z25-20020a6be219000000b006c213ef10a9mr7106915ioc.6.1667221974644; Mon, 31 Oct 2022 06:12:54 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id x6-20020a0566022c4600b0067fb21ad9c3sm2710500iov.22.2022.10.31.06.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 06:12:53 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 09:12:52 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1]. To: Xi Ruoyao , caiyinyu , adhemerval.zanella@linaro.org Cc: i.swmail@xen0n.name, libc-alpha@sourceware.org References: <20221031034334.3027740-1-caiyinyu@loongson.cn> <0a618c5f8c1d5a621e157a6167048c102fd8d501.camel@xry111.site> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <0a618c5f8c1d5a621e157a6167048c102fd8d501.camel@xry111.site> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/31/22 02:34, Xi Ruoyao via Libc-alpha wrote: > On Mon, 2022-10-31 at 11:43 +0800, caiyinyu wrote: >> [1]: >> https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=c4a7e6b56218e1d5a858682186b542e2eae01a4a;hp=0d94a8735055432029237612a6eb9165db1ec9dd >> [2]: >> Reference: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_e_flags_identifies_abi_type_and_version >> --- >>  elf/elf.h | 6 ++++-- >>  1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/elf/elf.h b/elf/elf.h >> index 3f08823a30..383eb5fbff 100644 >> --- a/elf/elf.h >> +++ b/elf/elf.h >> @@ -4093,8 +4093,10 @@ enum >>  #define R_NDS32_TLS_DESC       119 >>   >>  /* LoongArch ELF Flags */ >> -#define EF_LARCH_ABI           0x07 I assume this is a mask for the bits. >> -#define EF_LARCH_ABI_LP64D     0x03 > > Does Glibc API policy allow to remove a macro definition in a public > header? If a public glibc release has been made of this header then it is public ABI. How big is the LoongArch community? You could remove these things if you wanted, but it is not good for existing source compatibility. >> +#define EF_LOONGARCH_ABI_SOFT_FLOAT     0x1 >> +#define EF_LOONGARCH_ABI_SINGLE_FLOAT   0x2 >> +#define EF_LOONGARCH_ABI_DOUBLE_FLOAT   0x3 Best practice is to keep the old macro names around. Add the new macro names. The same value should have the *same* semantics, otherwise it's an ABI break. >> +#define EF_LOONGARCH_OBJABI_V1          0x40 >>   >>  /* LoongArch specific dynamic relocations */ >>  #define R_LARCH_NONE           0 > -- Cheers, Carlos.