From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>, Lukasz Majewski <lukma@denx.de>
Cc: Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
Andreas Schwab <schwab@linux-m68k.org>,
libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] ci: Check for necessary Debian packages when running build-many-glibcs.py
Date: Mon, 8 Nov 2021 14:06:47 -0300 [thread overview]
Message-ID: <b9d7c2a1-8c3e-6354-0991-55a347313dfe@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2111081657280.2331687@digraph.polyomino.org.uk>
On 08/11/2021 13:59, Joseph Myers wrote:
> On Mon, 8 Nov 2021, Lukasz Majewski wrote:
>
>> The same approach (with using the 'distro' python module) can be
>> applied to Fedora or Suse.
>
> That module isn't part of the Python standard library. I don't think we
> should introduce a dependency on it; rather, any use of it should be
> appropriately conditional, so the code still runs (without these checks)
> if the module is unavailable (importing produces an ImportError).
>
> In particular, even if the OS Python installation includes that module,
> the script should work with a separately built copy of Python without any
> such modules from the OS.
Maybe add a check without tying to any distribution (tool -v and some version
parsing).
>
>> +def check_os_requirements():
>> + if distro.id() == "debian" and distro.version() == "10":
>> + # List 'Debian' specific packages requirements (different than
>> + # vanila distro) to run this test without errors.
>> + debian_requirements = ['flex', 'bison', 'dnsutils', 'texinfo']
>
> Why is dnsutils needed?
Also, strictly to build and check 'texinfo' is not required either.
next prev parent reply other threads:[~2021-11-08 17:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 16:52 Lukasz Majewski
2021-11-08 16:59 ` Joseph Myers
2021-11-08 17:06 ` Adhemerval Zanella [this message]
2021-11-08 17:15 ` Florian Weimer
2021-11-08 19:44 ` Lukasz Majewski
2021-11-08 20:27 ` Adhemerval Zanella
2021-11-09 13:39 ` Lukasz Majewski
2021-11-09 13:43 ` Adhemerval Zanella
2021-11-09 15:32 ` Lukasz Majewski
2023-05-26 22:12 ` DJ Delorie
2023-05-26 22:34 ` Joseph Myers
2023-05-31 19:54 ` DJ Delorie
2023-05-31 20:18 ` DJ Delorie
2023-06-05 20:42 ` Adhemerval Zanella Netto
2023-06-05 21:12 ` DJ Delorie
2023-09-21 21:44 ` DJ Delorie
2023-10-09 18:23 ` Adhemerval Zanella Netto
2023-10-09 21:53 ` DJ Delorie
2021-11-08 18:15 ` Lukasz Majewski
2021-11-08 18:31 ` Joseph Myers
2021-11-08 19:51 ` Lukasz Majewski
2021-11-08 21:25 ` Joseph Myers
2021-11-08 17:17 ` Florian Weimer
2021-11-08 18:52 ` Joseph Myers
2021-11-08 19:03 ` Florian Weimer
2021-11-08 18:56 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d7c2a1-8c3e-6354-0991-55a347313dfe@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=lukma@denx.de \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).