From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id D847F3858D3C for ; Mon, 8 Nov 2021 17:06:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D847F3858D3C Received: by mail-oi1-x22b.google.com with SMTP id o83so28631950oif.4 for ; Mon, 08 Nov 2021 09:06:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JoV4L2gwCH/tgBN0Xpru7RAn4OJPhYvqu9vEuGDECQs=; b=szQ+zkZak2C1so075VyolPSu2O5ZBOAG48l/SGwqLX3PyR2f9tot4tSDWJGbJe36Zf 2kY4xY3Z0CQJi3zNNDbZndVU+T7yA1tWcKFLknlyMI4CkrhvfRWQrmzNbMojysOGJZ43 HjOLnVk3TTUVZ5TyIq6eCknffKPdOtw5znPGnQ3lLI0q4wElp4JlwmJTOdiQO5gBqvBP ulBQOyoAVlhY3AqYfelRvy0fBley+p1QmrjitMz+06V8mJj5DpD0nk4HSFDtOP8ooYsC gHWyT71aTHoK74eVpXTP682726dJGA44rw1DoUPXBX9lxv1Pyheux7+FGFs9YTdOfjfO VWwg== X-Gm-Message-State: AOAM533GLPaZCXpjwLwwYwS4YeC3wppqT/IFfBkafn8QfPB1CoZYu8oG uSWJrTJsgG/T9eqko6uaJHq4BpS/Fh5VUg== X-Google-Smtp-Source: ABdhPJzBKo+20xN/Fuw45XgBh4DfpOFevdPgHFl+0xOkd3I9PbThRQVP9o7+vBzhDn109TWmhX3k9A== X-Received: by 2002:aca:3455:: with SMTP id b82mr39280618oia.102.1636391209879; Mon, 08 Nov 2021 09:06:49 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:c067:29b:4c08:be99? ([2804:431:c7cb:55a:c067:29b:4c08:be99]) by smtp.gmail.com with ESMTPSA id j99sm5196447otj.19.2021.11.08.09.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 09:06:49 -0800 (PST) Message-ID: Date: Mon, 8 Nov 2021 14:06:47 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] ci: Check for necessary Debian packages when running build-many-glibcs.py Content-Language: en-US To: Joseph Myers , Lukasz Majewski Cc: Florian Weimer , Carlos O'Donell , Andreas Schwab , libc-alpha References: <20211108165255.15600-1-lukma@denx.de> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 17:06:53 -0000 On 08/11/2021 13:59, Joseph Myers wrote: > On Mon, 8 Nov 2021, Lukasz Majewski wrote: > >> The same approach (with using the 'distro' python module) can be >> applied to Fedora or Suse. > > That module isn't part of the Python standard library. I don't think we > should introduce a dependency on it; rather, any use of it should be > appropriately conditional, so the code still runs (without these checks) > if the module is unavailable (importing produces an ImportError). > > In particular, even if the OS Python installation includes that module, > the script should work with a separately built copy of Python without any > such modules from the OS. Maybe add a check without tying to any distribution (tool -v and some version parsing). > >> +def check_os_requirements(): >> + if distro.id() == "debian" and distro.version() == "10": >> + # List 'Debian' specific packages requirements (different than >> + # vanila distro) to run this test without errors. >> + debian_requirements = ['flex', 'bison', 'dnsutils', 'texinfo'] > > Why is dnsutils needed? Also, strictly to build and check 'texinfo' is not required either.