From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 68383388C001 for ; Tue, 22 Dec 2020 21:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68383388C001 Received: by mail-qt1-x82d.google.com with SMTP id z3so10001852qtw.9 for ; Tue, 22 Dec 2020 13:48:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EJJxfdhlgHOfAlbY1rugp+fOTtz7T5RiNaxD6vcZ68w=; b=Ut+bLc8Lvvgv7m0GaZloOKxAh7Erx4fshgxqN/s+M/ge1+v2F/MDnDV1ebqXzx0MHr ZgGhXh1eGfMIegdtLMk4WgysemKznHEuJdu76eENFbdrvremsinXkZB+nOMOH41mugfq Zs9K8hZer9uSzx/sgNIqm0SMTLXH3eN6UKpsDHmzp9CKmSuT08axX8SMETkkSCrXRzjG tMqAyVhmK3rLfqgVLUEFPP5+ic6Ta4o9zYEO/i1vMlh6bAuyAj68HoN7NNtspo8kYwJO iSNx09q8sxD8YHVGdY71W4x4cv5vIvZCFU7p5wZk5fvSKAoJgjDQYaA4b3DMAIsgm4Xu HlUA== X-Gm-Message-State: AOAM5319hE6tdsY8a5BmuPdBLi2jgzFfPSbirlqvVZlJm5khszd6DRso SjcRQEZJMzbgarPzCFDI/jxAOw== X-Google-Smtp-Source: ABdhPJybdZl7biA5GDQEKNSxm5JNNlJpbJcJ9p28cKijiBaqgi0aUm6WVyBcFybxuqqn/+yopciFSg== X-Received: by 2002:a05:622a:d1:: with SMTP id p17mr23267902qtw.233.1608673725867; Tue, 22 Dec 2020 13:48:45 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id a22sm13632841qkl.121.2020.12.22.13.48.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 13:48:45 -0800 (PST) To: Siddhesh Poyarekar , libc-alpha@sourceware.org Cc: fweimer@redhat.com, joseph@codesourcery.com References: <20201215141339.2684384-1-siddhesh@sourceware.org> <20201215141339.2684384-6-siddhesh@sourceware.org> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 5/5] x86 long double: Add tests for pseudo normal numbers Message-ID: Date: Tue, 22 Dec 2020 18:48:42 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201215141339.2684384-6-siddhesh@sourceware.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 21:48:50 -0000 On 15/12/2020 11:13, Siddhesh Poyarekar via Libc-alpha wrote: > Add some tests for fpclassify, isnanl, isinfl and issignaling. > --- > sysdeps/x86/fpu/Makefile | 3 +- > sysdeps/x86/fpu/test-unnormal.c | 196 ++++++++++++++++++++++++++++++++ > 2 files changed, 198 insertions(+), 1 deletion(-) > create mode 100644 sysdeps/x86/fpu/test-unnormal.c > > diff --git a/sysdeps/x86/fpu/Makefile b/sysdeps/x86/fpu/Makefile > index 600e42c3db..e77de56d14 100644 > --- a/sysdeps/x86/fpu/Makefile > +++ b/sysdeps/x86/fpu/Makefile > @@ -4,11 +4,12 @@ CPPFLAGS += -I../soft-fp > > libm-support += powl_helper > tests += test-fenv-sse test-fenv-clear-sse test-fenv-x87 test-fenv-sse-2 \ > - test-flt-eval-method-387 test-flt-eval-method-sse > + test-flt-eval-method-387 test-flt-eval-method-sse test-unnormal > CFLAGS-test-fenv-sse.c += -msse2 -mfpmath=sse > CFLAGS-test-fenv-clear-sse.c += -msse2 -mfpmath=sse > CFLAGS-test-fenv-sse-2.c += -msse2 -mfpmath=sse > CFLAGS-test-flt-eval-method-387.c += -fexcess-precision=standard -mfpmath=387 > CFLAGS-test-flt-eval-method-sse.c += -fexcess-precision=standard -msse2 \ > -mfpmath=sse > +CFLAGS-test-unnormal.c += -fsignaling-nans -std=c2x > endif A possibility is to hookup this tests on math/libm-test-{fpclassify,isnan,isinf,issignaling}.inc using the new define I suggested on the 4/5 part [1] so you can also check if no exceptions are being generated and errno is not set. It increases the tests coverage and avoid a arch-specific tests. [1] https://sourceware.org/pipermail/libc-alpha/2020-December/121004.html > diff --git a/sysdeps/x86/fpu/test-unnormal.c b/sysdeps/x86/fpu/test-unnormal.c > new file mode 100644 > index 0000000000..fc65d9290f > --- /dev/null > +++ b/sysdeps/x86/fpu/test-unnormal.c > @@ -0,0 +1,196 @@ > +/* Test long double classification with x86 pseudo normal numbers. > + Copyright (C) 2020 Free Software Foundation, Inc. > + > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > + > +struct tests > +{ > + const char *val; > + int class; > +} inputs[] = { > + /* Normal. */ > + {"\x00\x04\x00\x00\x00\x00\x00\x00\x00\x04", FP_NAN}, > + {"\x00\x04\x00\x00\x00\x00\x00\xf0\x00\x04", FP_NORMAL}, > + /* Pseudo-infinite. */ > + {"\x00\x00\x00\x00\x00\x00\x00\x00\xff\x7f", FP_NAN}, > + {"\x00\x00\x00\x00\x00\x00\x00\x80\xff\x7f", FP_INFINITE}, > + /* Pseudo-zero. */ > + {"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x01", FP_NAN}, > + {"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00", FP_ZERO}, > +}; > + I find this quite confusing to parse the value represented. I think it would be way more readable to include and define the values using the ieee_long_double_shape_type 'parts' member. If the idea is also to check snprintf, I think it would be better to the tests to a different test. Also make the inputs a 'static' variable. > +const char *classes[5]; > +#define stringify(N) #N > + > +static void > +initialize (void) > +{ > + classes[FP_NAN] = stringify(FP_NAN); > + classes[FP_INFINITE] = stringify(FP_INFINITY); > + classes[FP_ZERO] = stringify(FP_ZERO); > + classes[FP_SUBNORMAL] = stringify(FP_SUBNORMAL); > + classes[FP_NORMAL] = stringify(FP_NORMAL); > +} > + > +static void > +unnormal_str (const char *val, char *ret) > +{ > + for (int i = 9; i >= 0; i--) > + { > + if (i == 7 || i == 3) > + *ret++ = ' '; > + snprintf(ret, 3, "%02x", (unsigned char) val[i]); > + ret += 2; > + } > +} > + > +static int > +test_fpclassify (void) > +{ > + int ret = 0; > + > + printf ("* fpclassify tests:\n"); Maybe add the verbose output only when tests is invoke with --debug (same for other cases). > + for (int i = 0; i < sizeof (inputs)/sizeof (struct tests); i++) > + { > + long double value; > + char buf[22]; > + > + memcpy (&value, inputs[i].val, 10); > + unnormal_str(inputs[i].val, buf); > + int class = fpclassify(value); > + > + if (class != inputs[i].class) Use TEST_COMPARE. > + { > + printf ("0x%s: got %s, expected %s\n", buf, > + classes[fpclassify(value)], > + classes[inputs[i].class]); > + ret |= 1; > + } > + else > + printf ("0x%s: OK\n", buf); > + } > + return ret; > +} > + > +static int > +test_isinf (void) > +{ > + int ret = 0; > + > + printf ("* isinfl tests:\n"); > + for (int i = 0; i < sizeof (inputs)/sizeof (struct tests); i++) > + { > + long double value; > + char buf[22]; > + > + memcpy (&value, inputs[i].val, 10); > + unnormal_str(inputs[i].val, buf); > + int inf = isinf (value); > + > + if ((inputs[i].class == FP_INFINITE && inf) > + || (inputs[i].class != FP_INFINITE && !inf)) > + printf ("0x%s: OK\n", buf); > + else > + { > + printf ("0x%s: got %s, expected %s\n", buf, > + inf ? "INFINITE" : "NOT INFINITE", > + classes[inputs[i].class]); > + ret |= 1; > + } > + } > + > + return ret; > +} > + > +static int > +test_isnan (void) > +{ > + int ret = 0; > + > + printf ("* isnanl tests:\n"); > + for (int i = 0; i < sizeof (inputs)/sizeof (struct tests); i++) > + { > + long double value; > + char buf[22]; > + > + memcpy (&value, inputs[i].val, 10); > + unnormal_str(inputs[i].val, buf); > + int nan = isnan (value); > + > + if ((inputs[i].class == FP_NAN && nan) > + || (inputs[i].class != FP_NAN && !nan)) > + printf ("0x%s: OK\n", buf); > + else > + { > + printf ("0x%s: got %s, expected %s\n", buf, > + nan ? "NAN" : "NOT NAN", > + classes[inputs[i].class]); > + ret |= 1; > + } > + } > + return ret; > +} > + > +static int > +test_issignaling (void) > +{ > + int ret = 0; > + > + printf ("* issignaling tests:\n"); > + for (int i = 0; i < sizeof (inputs)/sizeof (struct tests); i++) > + { > + long double value; > + char buf[22]; > + > + memcpy (&value, inputs[i].val, 10); > + unnormal_str(inputs[i].val, buf); > + int signaling = issignaling (value); > + > + if ((inputs[i].class == FP_NAN && signaling) > + || (inputs[i].class != FP_NAN && !signaling)) > + printf ("0x%s: OK\n", buf); > + else > + { > + printf ("0x%s: got %s, expected %s\n", buf, > + signaling ? "SIGNALING" : "NOT SIGNALING", > + classes[inputs[i].class]); > + ret |= 1; > + } > + } > + return ret; > +} > + > +int > +do_test (void) > +{ > + int ret = 0; > + > + initialize (); > + > + ret |= test_fpclassify (); > + ret |= test_isinf (); > + ret |= test_isnan (); > + ret |= test_issignaling (); > + > + return ret; > +} > + > +#include >