From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A408F3858C39 for ; Wed, 6 Oct 2021 19:51:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A408F3858C39 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 196IVwVd029021; Wed, 6 Oct 2021 15:51:52 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bha60wpug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Oct 2021 15:51:52 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 196JgKB0006938; Wed, 6 Oct 2021 19:51:51 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma04wdc.us.ibm.com with ESMTP id 3bef2btdds-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Oct 2021 19:51:51 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 196JpoSI6095204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Oct 2021 19:51:50 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B609C2805E; Wed, 6 Oct 2021 19:51:50 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89C0828064; Wed, 6 Oct 2021 19:51:50 +0000 (GMT) Received: from [9.65.79.251] (unknown [9.65.79.251]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 6 Oct 2021 19:51:50 +0000 (GMT) Message-ID: Date: Wed, 6 Oct 2021 14:51:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 7/9] math: Remove powerpc e_hypot Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20211006180557.933826-1-adhemerval.zanella@linaro.org> <20211006180557.933826-8-adhemerval.zanella@linaro.org> From: Paul E Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: EQbCTxQAZDaNu-EDbLrzhjrn1Bk6yw9e X-Proofpoint-ORIG-GUID: EQbCTxQAZDaNu-EDbLrzhjrn1Bk6yw9e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-06_04,2021-10-06_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 mlxlogscore=890 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110060121 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TVD_SUBJ_WIPE_DEBT, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2021 19:51:56 -0000 On 10/6/21 2:46 PM, Adhemerval Zanella wrote: > > > On 06/10/2021 16:43, Paul E Murphy wrote: >> >> >> On 10/6/21 1:05 PM, Adhemerval Zanella via Libc-alpha wrote: >>> power9 master: >>> >>>    "hypot": { >>>     "workload-random": { >>>      "duration": 5.20744e+08, >>>      "iterations": 5.6e+07, >>>      "reciprocal-throughput": 9.27604, >>>      "latency": 9.32194, >>>      "max-throughput": 1.07805e+08, >>>      "min-throughput": 1.07274e+08 >>>     } >>>    } >>> >>> power9 patched: >>> >>>    "hypot": { >>>     "workload-random": { >>>      "duration": 5.23124e+08, >>>      "iterations": 5.4e+07, >>>      "reciprocal-throughput": 9.51892, >>>      "latency": 9.85606, >>>      "max-throughput": 1.05054e+08, >>>      "min-throughput": 1.0146e+08 >>>     } >>>    } >>> >>> power8 master: >>> >>>    "hypot": { >>>     "workload-random": { >>>      "duration": 5.21128e+08, >>>      "iterations": 4.6e+07, >>>      "reciprocal-throughput": 11.3589, >>>      "latency": 11.2988, >>>      "max-throughput": 8.80368e+07, >>>      "min-throughput": 8.85047e+07 >>>     } >>>    } >>> >>> power8 patched: >>> >>>    "hypot": { >>>     "workload-random": { >>>      "duration": 5.22651e+08, >>>      "iterations": 4.6e+07, >>>      "reciprocal-throughput": 11.3764, >>>      "latency": 11.3475, >>>      "max-throughput": 8.79009e+07, >>>      "min-throughput": 8.81252e+07 >>>     } >>>    } >>> >>> Checked on powerpc64-linux-gnu (power8) and powerpc64le-linux-gnu >>> (power9). >>> --- >>>   sysdeps/powerpc/fpu/e_hypot.c                 | 87 ------------------- >>>   sysdeps/powerpc/fpu/e_hypotf.c                | 78 ----------------- >>>   .../powerpc32/power4/fpu/multiarch/Makefile   |  5 +- >>>   .../power4/fpu/multiarch/e_hypot-power7.c     | 23 ----- >>>   .../power4/fpu/multiarch/e_hypot-ppc32.c      | 23 ----- >>>   .../powerpc32/power4/fpu/multiarch/e_hypot.c  | 33 ------- >>>   .../power4/fpu/multiarch/e_hypotf-power7.c    | 23 ----- >>>   .../power4/fpu/multiarch/e_hypotf-ppc32.c     | 23 ----- >>>   .../powerpc32/power4/fpu/multiarch/e_hypotf.c | 33 ------- >>>   9 files changed, 1 insertion(+), 327 deletions(-) >>>   delete mode 100644 sysdeps/powerpc/fpu/e_hypot.c >>>   delete mode 100644 sysdeps/powerpc/fpu/e_hypotf.c >>>   delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypot-power7.c >>>   delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypot-ppc32.c >>>   delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypot.c >>>   delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypotf-power7.c >>>   delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypotf-ppc32.c >>>   delete mode 100644 sysdeps/powerpc/powerpc32/power4/fpu/multiarch/e_hypotf.c >> >> This also removes the ppc specific hypotf too. Have you had a chance to measure the difference? >> >> I think it is OK if the performance difference is negligible. Though, I don't speak for the other ppc contributors in that regard. They may want to double-check the results. > > I would expect the performance difference to be similar to 64-bit, > at least on the hardware I checked (since most of the time would > be spent in FPU calculations). > > In any case, I don't see much gain in keeping a 32-bit powerpc > implementation that deviates from generic implementation. > Oops, I read this patch in isolation to the series. There probably isn't any difference. Sorry for the noise. Anyhow, in the context of the series, this looks OK to me.