From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by sourceware.org (Postfix) with ESMTPS id B3F82393BC3E for ; Wed, 3 Feb 2021 21:06:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3F82393BC3E Received: by mail-qv1-xf34.google.com with SMTP id h21so699154qvb.8 for ; Wed, 03 Feb 2021 13:06:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=669EW5DU6viI/M4wt/yDrBIUC0BUhCzrFCwrG7An6NA=; b=Sn8r4oDpyR4q2mDpNx9fv6Kpg+DtVesLEJ3LqMqBa/2PhePR0T+7VGs/WQbl60G1lr ZMJLl0t9xb00ofkaEzVK14rJlffeNYTfCJRdJUSWX8swsw1uWL4WidqlX6i0EKESM6gu 3Qu4iII6JJjj66WPio/Rt6U1bO8Ov3XICz2qJlA/biw56HaWLSn2FF/2007pPqJ6QyJh tJARhCFbYfEPL7gakwqyp2yKuGrvlOuIc2qBYxa422IqNLYhw/tfGtO3FNUdVcIPlnDr U7NY6s1GD1Y5aEAxUapQEuBToTuk0bozqQVzgD9im6+gNzztTsXIv5+Gd6B/hLtBLJtN v/fQ== X-Gm-Message-State: AOAM533x4sP6XBB7nImJ8+yz9jj+4JSkAuIz5kuujqaoC6djw4X5Ljws aAMY0QQoxbX0hQ1pi61VcmcStQ== X-Google-Smtp-Source: ABdhPJwBMFn6RZ709IJG7N1HU4QXyx2bLX823YVllpjnS4USbT9CGB0B70BMiB3MQFQCB02EWyPeYA== X-Received: by 2002:ad4:4b6d:: with SMTP id m13mr4806110qvx.56.1612386372271; Wed, 03 Feb 2021 13:06:12 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id d71sm2809213qkc.75.2021.02.03.13.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 13:06:11 -0800 (PST) To: Lukasz Majewski , Joseph Myers Cc: Paul Eggert , Alistair Francis , Arnd Bergmann , Alistair Francis , GNU C Library , Florian Weimer , Carlos O'Donell , Florian Weimer , Zack Weinberg References: <20210114163239.16505-1-lukma@denx.de> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH v2] tst: Provide test for ppoll Message-ID: Date: Wed, 3 Feb 2021 18:06:07 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210114163239.16505-1-lukma@denx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2021 21:06:14 -0000 On 14/01/2021 13:32, Lukasz Majewski wrote: > This change adds new test to assess ppoll()'s timeout related > functionality (the struct pollfd does not provide valid fd to wait > for - just wait for timeout). > > To be more specific - two use cases are checked: > - if ppoll() times out immediately when passed struct timespec has zero > values of tv_nsec and tv_sec. > - if ppoll() times out after timeout specified in passed argument > > --- > Changes for v2: > - Remove _GNU_SOURCE definition if not already defined > - Replace clock_gettime with xclock_gettime > - Use FAIL_EXIT1 instead of plain ret value returning from the test > --- > sysdeps/unix/sysv/linux/Makefile | 2 +- > sysdeps/unix/sysv/linux/tst-ppoll.c | 62 +++++++++++++++++++++++++++++ > 2 files changed, 63 insertions(+), 1 deletion(-) > create mode 100644 sysdeps/unix/sysv/linux/tst-ppoll.c > > diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile > index 7503b356c8..f4029a74ca 100644 > --- a/sysdeps/unix/sysv/linux/Makefile > +++ b/sysdeps/unix/sysv/linux/Makefile > @@ -108,7 +108,7 @@ tests += tst-clone tst-clone2 tst-clone3 tst-fanotify tst-personality \ > test-errno-linux tst-memfd_create tst-mlock2 tst-pkey \ > tst-rlimit-infinity tst-ofdlocks tst-gettid tst-gettid-kill \ > tst-tgkill tst-sysvsem-linux tst-sysvmsg-linux tst-sysvshm-linux \ > - tst-timerfd > + tst-timerfd tst-ppoll > tests-internal += tst-ofdlocks-compat tst-sigcontext-get_pc > > CFLAGS-tst-sigcontext-get_pc.c = -fasynchronous-unwind-tables Ok. > diff --git a/sysdeps/unix/sysv/linux/tst-ppoll.c b/sysdeps/unix/sysv/linux/tst-ppoll.c > new file mode 100644 > index 0000000000..eeff97f103 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/tst-ppoll.c > @@ -0,0 +1,62 @@ > +/* Test for ppoll timeout > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > +#include > + > +/* Timeout in seconds for PPOLL. */ > +#define PPOLL_TIMEOUT 2 > +/* Timeout for test program - must be larger than PPOLL_TIMEOUT. */ > +#define TIMEOUT 3 This define is unused. > + > +static int test_ppoll_timeout (int timeout) > +{ > + struct timespec tv0 = { 0, 0 }, tv1 = { 0, 0 }, tv = { 0, 0 }; > + struct pollfd fds = { -1, 0, 0 }; /* Ignore fds - just wait for timeout. */ > + int ret; > + > + tv.tv_sec = timeout; > + > + xclock_gettime (CLOCK_REALTIME, &tv0); > + > + ret = ppoll (&fds, 1, &tv, 0); > + if (ret != 0) > + FAIL_EXIT1 ("*** ppoll failed: %m\n"); > + > + xclock_gettime (CLOCK_REALTIME, &tv1); > + if (tv0.tv_sec + timeout != tv1.tv_sec) > + FAIL_EXIT1 ("*** ppoll failed to timeout after %d [s]\n", timeout); > + > + return 0; > +} > + > +static int > +do_test (void) > +{ > + /* Check if ppoll exits immediately. */ > + test_ppoll_timeout (0); > + > + /* Check if ppoll exits after specified timeout. */ > + test_ppoll_timeout (PPOLL_TIMEOUT); > + > + return 0; > +} > + > +#include The exactly timeout check is subjected to a scheduler pressure and it might indicate false positive depending of the system load. It would be better to check only if subsequent clock_gettime returns a time after previously than the ppoll check. Like: static int test_ppoll_timeout (bool zero_tmo) { /* We wait for half a second. */ struct timespec ts; xclock_gettime (CLOCK_REALTIME, &ts); struct timespec timeout = make_timespec (0, zero_tmo ? 0 : TIMESPEC_HZ/2); ts = timespec_add (ts, timeout); /* Ignore fds - just wait for timeout. */ struct pollfd fds = { -1, 0, 0 }; TEST_COMPARE (ppoll (&fds, 1, &timeout, 0), 0); TEST_TIMESPEC_NOW_OR_AFTER (CLOCK_REALTIME, ts); return 0; } static int do_test (void) { /* Check if ppoll exits immediately. */ test_ppoll_timeout (true); /* Check if ppoll exits after specified timeout. */ test_ppoll_timeout (false); return 0; }