From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by sourceware.org (Postfix) with ESMTPS id 67BF73945050 for ; Thu, 15 Apr 2021 12:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 67BF73945050 Received: by mail-qt1-x834.google.com with SMTP id u8so17872588qtq.12 for ; Thu, 15 Apr 2021 05:00:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h5ZYtgh8kAiT0AkPXIbf/wEAm7NjReNSQwT2V/7/SjY=; b=RU3t5y2mVjZ6ZjSioBk3U1EdLJFp++INotHW+JHSESEBvCF+uER2r2m9l7sxnjA21t 2x3NFVq9zMR6a34ADT/nmaq/IZzMVmhbDLzL9XYKFEV917Ir+0ExOyIkE2zp5roH0EW+ V+9mH7bMZQQ5yMPoDTJo7S4zSPSqm9i8Hd9ILMjX5pAtf8p+eazLgQ9IrgBm+9aVGP4d FqqBgZ0mmTSFo0uLbm/TGVVfbGpzMExP5K7wAapiZk1RsHgOJTi/BLK5hTJyWzD1Ozbi /VJrxAc3cm1E94VG+OppiLO1D2d8VdqZstc1WKz2+74yzkfR0s+RVMWcSv8/q9IpfyWa qrXQ== X-Gm-Message-State: AOAM532XtyJ1Jkk7vA+YIXs6QZVSSSDyhNjO+279N9z/bV3TtnDPIM6l OOAsxWyUgMP244HD7O4egk4oOByz+zGqw5tZ X-Google-Smtp-Source: ABdhPJxJ2gYU33whyZD14rEOLO3F0MJHUU58H9ZY4ejLUjMFbNXTmO6gIkBHI0a2umtvRmpwP3Ok/A== X-Received: by 2002:ac8:728d:: with SMTP id v13mr2684419qto.325.1618488015754; Thu, 15 Apr 2021 05:00:15 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id b20sm1750400qkn.111.2021.04.15.05.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Apr 2021 05:00:15 -0700 (PDT) Subject: Re: [PATCH 12/15] linux: mips: Split libpthread.abilist in n32 and n64 To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20210323134458.2563022-1-adhemerval.zanella@linaro.org> <20210323134458.2563022-13-adhemerval.zanella@linaro.org> <597b7571-2164-d0e7-62a9-5dd0493e4860@gotplt.org> From: Adhemerval Zanella Message-ID: Date: Thu, 15 Apr 2021 09:00:13 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <597b7571-2164-d0e7-62a9-5dd0493e4860@gotplt.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 12:00:17 -0000 On 15/04/2021 04:01, Siddhesh Poyarekar wrote: > On 3/23/21 7:14 PM, Adhemerval Zanella via Libc-alpha wrote: >> The n32 will require the 64 bit time symbols for y2038 support. >> --- > > A few symbols are missing in n32 and are there in n64.  Is that intentional?  I'd like to defer review for 12-15 to someone who can test this out. The symbol difference is because I pushed some patched for the libpthread removal project that removed some libpthread.abilist entries. But this patch is quite mechanical and it easily verified with a check-abi, so the rebase should be simple: $ cp sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist sysdeps/unix/sysv/linux/mips/mips64/n32/libpthread.abilist $ cp sysdeps/unix/sysv/linux/mips/mips64/libpthread.abilist sysdeps/unix/sysv/linux/mips/mips64/n64/libpthread.abilist And run a check-abi for mips64-linux-gnu and mips64-n32-linux-gnu. Same for patches 12-15, the tests should be to just simple ran make check-abi against the affected ABIs.