From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: Update kernel version to 6.2 in header constant tests
Date: Sat, 4 Mar 2023 12:16:39 -0500 [thread overview]
Message-ID: <bb37c38d-75fd-eb23-8d74-8bc477a7b967@redhat.com> (raw)
In-Reply-To: <67149734-443c-f12b-613-dbabd54a9ec@codesourcery.com>
On 2/23/23 19:23, Joseph Myers wrote:
> This patch updates the kernel version in the tests tst-mman-consts.py,
> tst-mount-consts.py and tst-pidfd-consts.py to 6.2. (There are no new
> constants covered by these tests in 6.2 that need any other header
> changes, and the removed MAP_VARIABLE for hppa was addressed
> separately.)
>
> Tested with build-many-glibcs.py.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
> diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> index 92b78a877c..ba6f21992a 100644
> --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py
> @@ -33,7 +33,7 @@ def main():
> help='C compiler (including options) to use')
> args = parser.parse_args()
> linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc)
> - linux_version_glibc = (6, 1)
> + linux_version_glibc = (6, 2)
OK. 1/3 required.
> sys.exit(glibcextract.compare_macro_consts(
> '#define _GNU_SOURCE 1\n'
> '#include <sys/mman.h>\n',
> diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> index d31b482adb..0845ada0ac 100755
> --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> @@ -39,10 +39,10 @@ def main():
> sys.exit (77)
>
> linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc)
> - # Constants in glibc were updated to match Linux v6.1. When glibc
> + # Constants in glibc were updated to match Linux v6.2. When glibc
> # constants are updated this value should be updated to match the
> # released kernel version from which the constants were taken.
> - linux_version_glibc = (6, 1)
> + linux_version_glibc = (6, 2)
OK. 2/3 required.
> def check(cte, exclude=None):
> return glibcextract.compare_macro_consts(
> '#include <sys/mount.h>\n',
> diff --git a/sysdeps/unix/sysv/linux/tst-pidfd-consts.py b/sysdeps/unix/sysv/linux/tst-pidfd-consts.py
> index 8df3fbd135..cafebb5d17 100644
> --- a/sysdeps/unix/sysv/linux/tst-pidfd-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-pidfd-consts.py
> @@ -39,7 +39,7 @@ def main():
> sys.exit (77)
>
> linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc)
> - linux_version_glibc = (6, 1)
> + linux_version_glibc = (6, 2)
OK. 3/3 required.
> sys.exit(glibcextract.compare_macro_consts(
> '#include <sys/pidfd.h>\n',
> '#include <asm/fcntl.h>\n'
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-03-04 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 0:23 Joseph Myers
2023-03-04 17:16 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb37c38d-75fd-eb23-8d74-8bc477a7b967@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).