From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: GNU C Library <libc-alpha@sourceware.org>
Cc: nd@arm.com
Subject: [PATCH 1/6] Use uint32_t sign in single precision math error handling, functions
Date: Wed, 27 Jun 2018 14:52:00 -0000 [thread overview]
Message-ID: <bb5159bb-d5d7-9e24-9b97-8ea6f70fc907@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
Ideally sign should be bool, but sometimes (e.g. in powf) it's more
efficient to pass a non-zero value than 1 to indicate that the sign
should be set. The fixed size int is less ambigous than unsigned
long.
2018-06-27 Szabolcs Nagy <szabolcs.nagy@arm.com>
* sysdeps/ieee754/flt-32/e_powf.c (__powf): Use uint32_t.
(exp2f_inline): Likewise.
* sysdeps/ieee754/flt-32/math_config.h (__math_oflowf): Likewise.
(__math_uflowf): Likewise.
(__math_may_uflowf): Likewise.
(__math_divzerof): Likewise.
(__math_invalidf): Likewise.
* sysdeps/ieee754/flt-32/math_errf.c (xflowf): Likewise.
(__math_oflowf): Likewise.
(__math_uflowf): Likewise.
(__math_may_uflowf): Likewise.
(__math_divzerof): Likewise.
(__math_invalidf): Likewise.
---
sysdeps/ieee754/flt-32/e_powf.c | 4 ++--
sysdeps/ieee754/flt-32/math_config.h | 8 ++++----
sysdeps/ieee754/flt-32/math_errf.c | 10 +++++-----
3 files changed, 11 insertions(+), 11 deletions(-)
[-- Attachment #2: 0001-Use-uint32_t-sign-in-single-precision-math-error-han.patch.diff --]
[-- Type: text/x-patch, Size: 2894 bytes --]
diff --git a/sysdeps/ieee754/flt-32/e_powf.c b/sysdeps/ieee754/flt-32/e_powf.c
index 90661e2216..ece83f0dd2 100644
--- a/sysdeps/ieee754/flt-32/e_powf.c
+++ b/sysdeps/ieee754/flt-32/e_powf.c
@@ -84,7 +84,7 @@ log2_inline (uint32_t ix)
(in case of fast toint intrinsics) or not. The unscaled xd must be
in [-1021,1023], sign_bias sets the sign of the result. */
static inline double_t
-exp2_inline (double_t xd, unsigned long sign_bias)
+exp2_inline (double_t xd, uint32_t sign_bias)
{
uint64_t ki, ski, t;
/* double_t for better performance on targets with FLT_EVAL_METHOD==2. */
@@ -143,7 +143,7 @@ zeroinfnan (uint32_t ix)
float
__powf (float x, float y)
{
- unsigned long sign_bias = 0;
+ uint32_t sign_bias = 0;
uint32_t ix, iy;
ix = asuint (x);
diff --git a/sysdeps/ieee754/flt-32/math_config.h b/sysdeps/ieee754/flt-32/math_config.h
index c4def9bbc1..9c4ef30173 100644
--- a/sysdeps/ieee754/flt-32/math_config.h
+++ b/sysdeps/ieee754/flt-32/math_config.h
@@ -102,10 +102,10 @@ issignalingf_inline (float x)
#define NOINLINE __attribute__ ((noinline))
-attribute_hidden float __math_oflowf (unsigned long);
-attribute_hidden float __math_uflowf (unsigned long);
-attribute_hidden float __math_may_uflowf (unsigned long);
-attribute_hidden float __math_divzerof (unsigned long);
+attribute_hidden float __math_oflowf (uint32_t);
+attribute_hidden float __math_uflowf (uint32_t);
+attribute_hidden float __math_may_uflowf (uint32_t);
+attribute_hidden float __math_divzerof (uint32_t);
attribute_hidden float __math_invalidf (float);
/* Shared between expf, exp2f and powf. */
diff --git a/sysdeps/ieee754/flt-32/math_errf.c b/sysdeps/ieee754/flt-32/math_errf.c
index 7d58c0b855..5bc7ac6ef5 100644
--- a/sysdeps/ieee754/flt-32/math_errf.c
+++ b/sysdeps/ieee754/flt-32/math_errf.c
@@ -33,14 +33,14 @@ with_errnof (float y, int e)
/* NOINLINE prevents fenv semantics breaking optimizations. */
NOINLINE static float
-xflowf (unsigned long sign, float y)
+xflowf (uint32_t sign, float y)
{
y = (sign ? -y : y) * y;
return with_errnof (y, ERANGE);
}
attribute_hidden float
-__math_uflowf (unsigned long sign)
+__math_uflowf (uint32_t sign)
{
return xflowf (sign, 0x1p-95f);
}
@@ -49,20 +49,20 @@ __math_uflowf (unsigned long sign)
/* Underflows to zero in some non-nearest rounding mode, setting errno
is valid even if the result is non-zero, but in the subnormal range. */
attribute_hidden float
-__math_may_uflowf (unsigned long sign)
+__math_may_uflowf (uint32_t sign)
{
return xflowf (sign, 0x1.4p-75f);
}
#endif
attribute_hidden float
-__math_oflowf (unsigned long sign)
+__math_oflowf (uint32_t sign)
{
return xflowf (sign, 0x1p97f);
}
attribute_hidden float
-__math_divzerof (unsigned long sign)
+__math_divzerof (uint32_t sign)
{
float y = 0;
return with_errnof ((sign ? -1 : 1) / y, ERANGE);
next reply other threads:[~2018-06-27 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 14:52 Szabolcs Nagy [this message]
2018-06-28 17:15 ` Joseph Myers
-- strict thread matches above, loose matches on Subject: below --
2018-06-27 14:50 Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb5159bb-d5d7-9e24-9b97-8ea6f70fc907@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).