From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 002023857371 for ; Fri, 15 Apr 2022 01:27:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 002023857371 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxnxPuyVhiIMkjAA--.16396S3; Fri, 15 Apr 2022 09:27:34 +0800 (CST) From: caiyinyu Subject: Re: [PATCH v2 00/14] GLIBC LoongArch PATCHES To: Joseph Myers Cc: libc-alpha@sourceware.org, xuchenghua@loongson.cn References: <20211231064455.1030051-1-caiyinyu@loongson.cn> Message-ID: Date: Fri, 15 Apr 2022 09:27:10 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID: AQAAf9DxnxPuyVhiIMkjAA--.16396S3 X-Coremail-Antispam: 1UD129KBjvJXoWxZw18tF4UXF17WryDGFy8Xwb_yoW5Wr1Up3 45Gw1akF9xtryIyas2qw4xW345JrZ3Cry5Jas7X3s8Ars8G3Z5KrWYqrZ5Xa47ArZ5WrWY yryfGFnrKan0vFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvm14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r 4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2Wl Yx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbV WUJVW8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7I2V7IY0VAS07Al zVAYIcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnU UI43ZEXa7VUbrMaUUUUUU== X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_SHORT, MIME_CHARSET_FARAWAY, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Apr 2022 01:27:45 -0000 ÔÚ 2022/1/1 ÉÏÎç1:34, Joseph Myers дµÀ: > On Fri, 31 Dec 2021, caiyinyu wrote: > >> b. >> FAIL: elf/ifuncmain1 >> FAIL: elf/ifuncmain1pic >> FAIL: elf/ifuncmain1pie >> FAIL: elf/ifuncmain1staticpic >> FAIL: elf/ifuncmain1staticpie >> FAIL: elf/ifuncmain1vis >> FAIL: elf/ifuncmain1vispic >> FAIL: elf/ifuncmain1vispie >> FAIL: elf/ifuncmain3 >> FAIL: elf/ifuncmain4 >> FAIL: elf/ifuncmain6pie >> FAIL: elf/ifuncmain7 >> FAIL: elf/ifuncmain7pic >> FAIL: elf/ifuncmain7pie >> FAIL: elf/tst-ifunc-fault-bindnow >> FAIL: elf/tst-ifunc-fault-lazy >> >> ifunc functions are not support yet > If IFUNC isn't supported, the configure test > (libc_cv_ld_gnu_indirect_function) should fail, have-ifunc should be no > and elf/Makefile should disable the tests. > > Those failures suggest you have partial support in the toolchain - enough > binutils support for the tests to be enabled - but are either missing > glibc support, or some of the toolchain support is broken. In that case, > you should fix/add the broken/missing support so that the tests pass. (Or > if it's wrong that the libc_cv_ld_gnu_indirect_function test passes at > all, maybe that's a binutils bug and you need to fix the binutils port so > that that configure test fails.) All ifunc problems are fixed. >> c. >> FAIL: math/test-double-acos >> FAIL: math/test-double-asin >> FAIL: math/test-float32x-acos >> FAIL: math/test-float32x-asin >> FAIL: math/test-float64-acos >> FAIL: math/test-float64-asin >> >> These fails are caused by gcc optimizations. if we use -O0 options, these fails >> will pass. > So that issue needs fixing in GCC upstream. GCC fixed. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95115 >> 10. Note the need for a manual/math.texi update in the list of >> configurations supporting _Float128. >> >> not support yet > It's supported by the port (with the same ABI as long double, via the > ieee754/ldbl-128 inclusion in sysdeps/loongarch/Implies) - the functions > are in the ABI test baselines. So you need to update math.texi to reflect > that. Fixed. >> 13. arch_minimum_kernel should be set to 10.0.0 until the actual upstream >> kernel version that gets the port is known, and then to the actual >> upstream version (so 5.14.0 or later). Accordingly, kernel-features.h >> should not have any "before 4.20" conditionals in it (so you don't need an >> architecture-specific kernel-features.h at all). >> >> corrected > You have arch_minimum_kernel=5.15.0, but the support isn't in 5.15.0, and > indeed isn't in Linus's git tree for 5.16 either. > > Once it's in Linus's git tree, you can set arch_minimum_kernel to the > actual version that will have the port. Until then, you should use 10.0.0 > as a placeholder. Fixed.