Re: [PATCH] elf/tests: Make thrlock and noload depend on libm

[Siddhesh Poyarekar <siddhesh@sourceware.org>]

On 7/8/21 11:39 AM, Florian Weimer via Libc-alpha wrote:
> * Siddhesh Poyarekar:
> 
>> Oh, and running only tests (assuming that all built objects are up to
>> date) won't do this.  It'll only happen if some object needs to be
>> updated when the test is run because an undercaffeinated developer ran
>> make check instead of make && make check :)
> 
> If you do that, you'll likely end up with corrupt objects anyway.
> I think some assert in allocatestack.c is particularly common
> (or at least was when we still had a separate libpthread).  It
> definitely invalidates testing.
> 
> We really need to fix that, but the dependency won't help with that.
> (But as I said, adding the dependency is correct, just the commit
> message is misleading.)

OK, I'll update the commit message to say:

Both tests try to dlopen libm.so at runtime, so make them depend on it 
so that they're executed if libm.so has been updated.

Siddhesh