From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id 9CD663858C2F for ; Thu, 25 Aug 2022 17:01:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CD663858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-11c5505dba2so25647293fac.13 for ; Thu, 25 Aug 2022 10:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc; bh=aLE3ugpxIuiqjM2lMULdtBdz2giGJKkcqJno4IL2HNg=; b=lGXZTH1xIBcvVHtW3eeMHYmFjqT8h4aWSJ49PC35ykIiGEtBuwuSZ6mDCsNN/08pTs 5i53lSjC+1j9oDe0NwOh3yqp4APcQmnyCMOAPtaJ1e/XqCoLCsMJL6j37WygJ5mMBuZn tB5McxaLeekWa0GNACpQP+iv24NbWEuZEo4hKcNAPWlWF1I6Pkqs87muR+8jjTOJsr6E dGD/vtgCxWiWHzxshtGIk8W9LMIi+HtqXT5ZYAI+lGv0ICCsnl034Z/B3Rn16hA1Qovz 88/n/YuvBbkombZVdUNwNDq5kklAAN1ll9oTQzfNlXbVFpWt1eB/1j+ZuMSB2Pd3zDwd WBhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=aLE3ugpxIuiqjM2lMULdtBdz2giGJKkcqJno4IL2HNg=; b=WhuW+FfDGuc98zN+utVUUIJLsSilMGmqI5aNoDpxzdEjzu/HZhZ/8xKonQj0t1+tpT h4gPjL8GLx6CvObV2Gkr+DkjZCgPC1yMjeBDYv+xkt013RgYMKWxfSzwJ3DL0qYrbR5o N4I9eXkYzo3StlSFm4U45bzT7DtJsQCoEo1g9Xxwy2q/zU1pmTUf0T51/7NZnh1YGaBX +8hF4A1WiAz1vrZEn+rbfsk3PohSQV/j2D3KF+PFuKljmqV72GrjHRotnozJ1/bWo+XR Zzq81gmwyC+Dafv6aSdKRCCK/TMaV8UV+DJMxA2yyWY2TBNJZ1gsLAS/atZnzGhVpSKU gNhA== X-Gm-Message-State: ACgBeo3vlHS6Ew2wXpj7aVPDZYJto61xfevYmyjLbqz5RiqX3HUD1/Nw QKK1dye02WQZZt8604cJm94JKstm3FR85Q== X-Google-Smtp-Source: AA6agR6rmTWRnqR/6VZKmUjOS5pvjFRiWzB3xIypZlBuqdaZxiSVd0AUOWeJTN3z5Xq1vLXCrVfAGw== X-Received: by 2002:a05:6870:73cd:b0:11d:2a3:7fdf with SMTP id a13-20020a05687073cd00b0011d02a37fdfmr26594oan.98.1661446868931; Thu, 25 Aug 2022 10:01:08 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:745e:786a:689c:f1e5:7517? ([2804:1b3:a7c0:745e:786a:689c:f1e5:7517]) by smtp.gmail.com with ESMTPSA id g61-20020a9d12c3000000b006392c93c5aasm3121111otg.42.2022.08.25.10.01.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Aug 2022 10:01:04 -0700 (PDT) Message-ID: Date: Thu, 25 Aug 2022 14:01:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 1/2] LoongArch: Fix ptr mangling/demangling features. Content-Language: en-US To: Xi Ruoyao , caiyinyu , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name Cc: xuchenghua@loongson.cn References: <20220823122833.1561228-1-caiyinyu@loongson.cn> <20220823122833.1561228-2-caiyinyu@loongson.cn> <8562da19-d9d3-a4f3-2aae-2a4489af6806@linaro.org> <627c332247e2a3ce48658e2d531f6d7a7df19312.camel@xry111.site> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <627c332247e2a3ce48658e2d531f6d7a7df19312.camel@xry111.site> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25/08/22 12:27, Xi Ruoyao wrote: > On Thu, 2022-08-25 at 12:08 -0300, Adhemerval Zanella Netto wrote: >> Does is really pay off the complexity to use HAVE_LOONGARCH_EXPLICIT_RELOCS? The >> PTR_MANGLE is used some specific cases and hardly a hotstop. > > LDST_PCREL added as a macro in sysdep.h, so further assembly > implementations might reuse it then it may appear in some hot spot. > > If we quote "optimization too early is the ultimate evil", we can drop > it for now and review once we use LDST_PCREL somewhere else. But to me > this is rather a simple autoconf check and I can't figure out a > situation where it's evil... It is more that configure checks might create maintainability burden or just dead code in the long term, specially where it does have a fallback that works with no much performance penalty.