From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id DF6A33857C66 for ; Wed, 12 Jul 2023 08:59:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF6A33857C66 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1689152381; bh=Uf3dlvO+R5t3vOuF/MpaLRPpytoeoFdk79Dw7Chg/5U=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MzMqPmXAb+vb4y+Oj5My3Hvcb0LmD/AAmFv8UNYau62NBIyDnNULF2Kc4a8mYyVxI aDG7G+XYj23Hpw6cgi5pQnrP87M/YgxkRwB1yPhcnUpG2qCHfTMVZxEtMVq+DY03XX 9xsdl0HrdvEDjMJsXr7iOTQsWMgknLcH+19aZAOU= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id CD8ED65CE8; Wed, 12 Jul 2023 04:59:39 -0400 (EDT) Message-ID: Subject: Re: [PATCH v5] libio: Add nonnull attribute for most FILE * arguments in stdio.h From: Xi Ruoyao To: Siddhesh Poyarekar , Zack Weinberg , Jeff Law , GNU libc development Cc: Adhemerval Zanella , Carlos O'Donell , "'Alejandro Colomar (man-pages)'" , Andreas Schwab , David Malcolm Date: Wed, 12 Jul 2023 16:59:38 +0800 In-Reply-To: <0a54dc17-fa8c-cba1-66c9-fb2a427d85b0@gotplt.org> References: <20230710161300.1678172-1-xry111@xry111.site> <60947356-1710-4658-9169-9535505befd4@app.fastmail.com> <5d050e86-4c98-de22-5ef0-4cc9ead273d7@gotplt.org> <18affbe3-00c1-1cb1-6860-f7c78585f52b@gotplt.org> <25b31a74-5f06-1cce-dca5-ae84666c92b7@gmail.com> <2b0a78ff42fb00b92cf7a2d940dfeb141b0dfcfe.camel@xry111.site> <7ae4346f-f803-4d0f-8317-04a6d2ea2116@app.fastmail.com> <0a832d2f597a363e55aa69281dcbab200ade3bc1.camel@xry111.site> <0a54dc17-fa8c-cba1-66c9-fb2a427d85b0@gotplt.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2023-07-11 at 16:12 -0400, Siddhesh Poyarekar wrote: > > I raised an objection to Xi's patches (adding non-null annotations > > to > > stdio.h in particular) specifically because of the timing.=C2=A0 Having > > thought about it some more, I'm fine with having those annotations, > > but > > I think it is unwise to *add* them to such a widely-used, > > standardized > > header right before a release freeze.=C2=A0 Instead, I'd like to see Xi= 's > > patches land on trunk almost immediately after the 2.38 release > > branch > > is created, so that we have the maximum amount of time to find any > > problems before 2.39. >=20 > Xi, if you're still interested, can you please post a v6 with=20 > annotations to the _chk variants of the functions and in stdio2.h as > well? https://patchwork.sourceware.org/project/glibc/patch/20230712085615.1373977= -1-xry111@xry111.site/ --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University