From: Stefan Liebler <stli@linux.ibm.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] string: Add hidden builtin definition for __strcpy_chk.
Date: Tue, 6 Feb 2024 09:19:01 +0100 [thread overview]
Message-ID: <bc6eea87-0058-4ed0-872d-4fe0502a029c@linux.ibm.com> (raw)
In-Reply-To: <878ccbd7-55a8-4129-af0b-2a5d25544f15@linaro.org>
On 05.02.24 19:12, Adhemerval Zanella Netto wrote:
>
>
> On 05/02/24 10:22, Stefan Liebler wrote:
>> Otherwise on at least x86_64 and s390x there is an unwanted PLT entry
>> in libc.so when configured with --enable-fortify-source and build
>> with -Os.
>
> I think it would be useful to add that it also requires --enable-fortify-source=3
> to trigger it.
I've double checked with my builds. For me it is also level 3. I've
adjusted it in the commit message.
>
>>
>> This is observed in elf/check-localplt
>> Extra PLT reference: libc.so: __strcpy_chk
>>
>> The call to PLT entry is in inet/ruserpass.c.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
Thanks for reviewing. I've just committed the patch
prev parent reply other threads:[~2024-02-06 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:22 Stefan Liebler
2024-02-05 18:12 ` Adhemerval Zanella Netto
2024-02-06 8:19 ` Stefan Liebler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc6eea87-0058-4ed0-872d-4fe0502a029c@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).