From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id EA7983858C53 for ; Tue, 6 Feb 2024 08:19:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA7983858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA7983858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707207551; cv=none; b=qB0fLu8n8Red5rD4orVRwtn2H7JnHueTrTfKjcY3QudN89zyRw67rsf4QysfbvKFJOQT/J3FCnHz/fWCTbnSAKaDBsS41k3acPSSMvNsaNe/Jvg4akfnnuqIxjWel3AElB8OQTk0gWo4tdFqaQOiywcs3MYwYQIJOvBvrXY/QGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707207551; c=relaxed/simple; bh=zWkRStjYJhmX+hvQaQo9+nip8DE2tUY5xD5ZZgr4YD4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=h2LtzF3ceIQHYZPtYkTydN64cNWvkwsVLBX4sA0nkSUp4O0qDEX37gUUHWUvMc6cMv8HzhVyr1SXJt0uZast1yoz7KK/vJDuWFXTsYlsR2/fUgKaLtN9l0Dh/t4cgWuADy47zzw2vaFB9dkHNHvVlkfbrrJp/Hl5bH0YYzmjAQ8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4168DOa6012515; Tue, 6 Feb 2024 08:19:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=3WoWMQUlSBwGbmhr1erE4qTz9JdEi6BXeAyPzwfFnnY=; b=BNKCkNjBduekHbggNPv47fqcWmdZPLJvlmZ5XMbwrNsCoMxcU0bWW0Z6HCpcaxFR+6+A Nr0AkhMq3bsiwwfQIuMnBfVErS0OSVGIzqqluJd+yu572FuYr/pKZocOP6xys4d0Ihrz h3uIHEoI0NtEax9wbbWtciP0C7zXfcZVJQZwePaPhD0ifJPE9ZSYIqu4ki3F0O9QY6fi I6kUQ+AgDKcDe3WQFiFZR4/MocxBi42qiA32P1X37DJt2rb+cOopORpvqJ5oKcb1Xuv2 0fNF3NfqK2vYxtsFo2wRGQS1/MinCMLgsgcL/cwDoBknvgicHGPKUN7BGDbw6i3grQ4b ZQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w3h2j04qy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Feb 2024 08:19:04 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41673uCa005430; Tue, 6 Feb 2024 08:19:04 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3w21akdmbw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Feb 2024 08:19:04 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4168J23i23003812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 6 Feb 2024 08:19:02 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0F7F42004B; Tue, 6 Feb 2024 08:19:02 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DD47F20040; Tue, 6 Feb 2024 08:19:01 +0000 (GMT) Received: from [9.171.3.222] (unknown [9.171.3.222]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 6 Feb 2024 08:19:01 +0000 (GMT) Message-ID: Date: Tue, 6 Feb 2024 09:19:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] string: Add hidden builtin definition for __strcpy_chk. To: Adhemerval Zanella Netto , libc-alpha@sourceware.org References: <20240205132206.1603576-1-stli@linux.ibm.com> <878ccbd7-55a8-4129-af0b-2a5d25544f15@linaro.org> Content-Language: en-US From: Stefan Liebler In-Reply-To: <878ccbd7-55a8-4129-af0b-2a5d25544f15@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZepvqBvTmrsILiWFI0WwOXD2_bGx6eVN X-Proofpoint-GUID: ZepvqBvTmrsILiWFI0WwOXD2_bGx6eVN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-06_02,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 adultscore=0 mlxlogscore=653 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402060057 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.02.24 19:12, Adhemerval Zanella Netto wrote: > > > On 05/02/24 10:22, Stefan Liebler wrote: >> Otherwise on at least x86_64 and s390x there is an unwanted PLT entry >> in libc.so when configured with --enable-fortify-source and build >> with -Os. > > I think it would be useful to add that it also requires --enable-fortify-source=3 > to trigger it. I've double checked with my builds. For me it is also level 3. I've adjusted it in the commit message. > >> >> This is observed in elf/check-localplt >> Extra PLT reference: libc.so: __strcpy_chk >> >> The call to PLT entry is in inet/ruserpass.c. > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella > Thanks for reviewing. I've just committed the patch