From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 5B0433858C78 for ; Wed, 21 Jun 2023 07:13:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B0433858C78 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1687331605; bh=RGObdkj7CSC1EgAilbyN9n8524q63143m1dVL7GBwns=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=JBhKhrw+vsTbkviNaUuuW1XwNRGLvYn5WrORQOHQ9OC6e5hSd8TNFfb7c83/xzZ93 noqn/Bka3K+eTPiEUbW8r2shlYGG/aCl5GmdXPcphXVCBOBrPU5ZkS06WbGQpFElt7 JgJCFBdVl/WPe5oN0C8iBc4eRaXkZOQwRYwv0KE8= Received: from [IPv6:240e:358:11d3:9400:dc73:854d:832e:3] (unknown [IPv6:240e:358:11d3:9400:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 9B87B66311; Wed, 21 Jun 2023 03:13:21 -0400 (EDT) Message-ID: Subject: Re: [PATCH v2 1/4] clang-format: should format with 2 space and do not usage tab From: Xi Ruoyao To: luoyonggang@gmail.com Cc: Zack Weinberg , Jens Gustedt , GNU libc development , Florian Weimer Date: Wed, 21 Jun 2023 15:13:14 +0800 In-Reply-To: References: <20230620171731.230-1-luoyonggang@gmail.com> <20230620171731.230-2-luoyonggang@gmail.com> <2c0b7268-4efd-4ace-beef-9155501ed700@app.fastmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 MIME-Version: 1.0 X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2023-06-21 at 14:55 +0800, =E7=BD=97=E5=8B=87=E5=88=9A(Yonggang Luo= ) wrote: > > Because the existing code uses one tab for 8 spaces.=C2=A0 Glibc has it= s own > > coding standard, not "what you prefer". >=20 > I am also talking about the existing code, so the conclusion is the exist= ing code=C2=A0 > is not consistent, some use one tab for 8 spaces, some use spaces directl= y Anyway "TabWidth: 2" is wrong. If you want to avoid tab at all, the TabWidth setting is irrelevant and should be removed. We already have "UseTab: Always" and "IndentWidth: 2", these matches the description of Zack. As the patch adding .clang-format had been reviewed (the commit adding it even contains an R-b tag from Carlos), it implies the current consensus for new code is to *always* tabs for=C2=A08 spaces. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University