From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v9 5/9] x86: Add SSE2 optimized chacha20
Date: Wed, 13 Jul 2022 15:29:05 -0300 [thread overview]
Message-ID: <bcfe6ae0-d3b9-530c-225e-6383c78027c6@linaro.org> (raw)
In-Reply-To: <CAFUsyf+jvtc0UFOkUTspc460_z0ABbax1jifoEZ993WGuOwqfQ@mail.gmail.com>
On 13/07/22 15:27, Noah Goldstein wrote:
>>>>> +
>>>>
>>>> If you have time make the ifunc changes to avx2 can you add:
>>>>
>>>> #include <isa-level.h>
>>>> #if MINIMUM_X86_ISA_LEVEL <= 1
>>>> <contentions of file>
>>>> #endif
>>>>
>>>> as a build guard?
>>>
>>> Alright, I will add it.
>
> Err it should be
> #if MINIMUM_X86_ISA_LEVEL <= 2
>
> sorry.
I think it makes more sense to add the #if MINIMUM_X86_ISA_LEVEL <= 2 check
on the AVX2 patch, since this patch isolated is required for all ISA levels.
next prev parent reply other threads:[~2022-07-13 18:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 17:36 [PATCH v9 0/9] Add arc4random support Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 1/9] stdlib: Add arc4random, arc4random_buf, and arc4random_uniform (BZ #4417) Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 2/9] stdlib: Add arc4random tests Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 3/9] benchtests: Add arc4random benchtest Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 4/9] aarch64: Add optimized chacha20 Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 5/9] x86: Add SSE2 " Adhemerval Zanella
2022-07-13 18:12 ` Noah Goldstein
2022-07-13 18:20 ` Adhemerval Zanella Netto
2022-07-13 18:22 ` Noah Goldstein
2022-07-13 18:27 ` Noah Goldstein
2022-07-13 18:29 ` Adhemerval Zanella Netto [this message]
2022-07-13 18:53 ` Noah Goldstein
2022-07-13 17:36 ` [PATCH v9 6/9] x86: Add AVX2 " Adhemerval Zanella
2022-07-13 18:07 ` Noah Goldstein
2022-07-13 19:31 ` Adhemerval Zanella Netto
2022-07-13 20:24 ` Noah Goldstein
2022-07-13 20:16 ` Florian Weimer
2022-07-13 20:23 ` Noah Goldstein
2022-07-13 17:36 ` [PATCH v9 7/9] powerpc64: Add " Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 8/9] s390x: " Adhemerval Zanella
2022-07-13 17:36 ` [PATCH v9 9/9] manual: Add documentation for arc4random functions Adhemerval Zanella
2022-07-14 10:03 ` Mark Harris
2022-07-14 11:08 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcfe6ae0-d3b9-530c-225e-6383c78027c6@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).