From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id 170D03856DCA for ; Wed, 13 Jul 2022 18:29:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 170D03856DCA Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-10c0d96953fso15145664fac.0 for ; Wed, 13 Jul 2022 11:29:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=k9ktZvAcCMOjrmKy0n+8At6GH2DOwDEpD6ompiiCy8A=; b=KsDyl4sbp7+1xxz07jVxsGsU5EXrSG3Jqbyoe7AtIxyn57MWd4Rx/qJs4px+gUgZFQ ZMKQZ9s5gs8x94ARdmz/NUU9WS5LUC3vfrc3kgTXYeC4a/5oX11V0SD55W4cGUQN7sZy hk/SV1TUwf2dKJg5trx5t9XJnwA9vD66mKTm72+s2NfaG8SbUa7IGtVzAQBbwcTUfy2m 3d4+3dbkmlT+iZlyMfUxzAisY/mZavN9RTqwVlZBBS1DmLfqJpoWz0gxy++CWJESMylc HCtLGwr0ZYpgVXHNcGYzNQjH6x2XXgJ7amKxmyiMgm//P2y1LOyat9gPKaZaZL0BXuD7 zPIA== X-Gm-Message-State: AJIora8V1c4YBUpRr4J72iOp9OZQ9Rl1mwn+oBD1wqPxNbG/Rnmg6IxO 1JXMc1kTVSxtHpSP6wIwag0nRQ== X-Google-Smtp-Source: AGRyM1sItECsKsXP3t823PpuuKI80xwKdBY07ANUYWSRhg8XYimQX5W2lOXax9gC3Ndmqw7hzkOLkg== X-Received: by 2002:a05:6870:d599:b0:101:652e:fae0 with SMTP id u25-20020a056870d59900b00101652efae0mr5184469oao.285.1657736948438; Wed, 13 Jul 2022 11:29:08 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:19c3:4427:c171:4fa9:c3d9? ([2804:431:c7ca:19c3:4427:c171:4fa9:c3d9]) by smtp.gmail.com with ESMTPSA id t67-20020a4a5446000000b0042bd87fd123sm5093692ooa.19.2022.07.13.11.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 11:29:08 -0700 (PDT) Message-ID: Date: Wed, 13 Jul 2022 15:29:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v9 5/9] x86: Add SSE2 optimized chacha20 Content-Language: en-US To: Noah Goldstein Cc: GNU C Library , Florian Weimer References: <20220713173657.516725-1-adhemerval.zanella@linaro.org> <20220713173657.516725-6-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 18:29:10 -0000 On 13/07/22 15:27, Noah Goldstein wrote: >>>>> + >>>> >>>> If you have time make the ifunc changes to avx2 can you add: >>>> >>>> #include >>>> #if MINIMUM_X86_ISA_LEVEL <= 1 >>>> >>>> #endif >>>> >>>> as a build guard? >>> >>> Alright, I will add it. > > Err it should be > #if MINIMUM_X86_ISA_LEVEL <= 2 > > sorry. I think it makes more sense to add the #if MINIMUM_X86_ISA_LEVEL <= 2 check on the AVX2 patch, since this patch isolated is required for all ISA levels.