From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id B63D23858000 for ; Tue, 21 May 2024 12:32:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B63D23858000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B63D23858000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716294777; cv=none; b=aavSon75J7sgXKf0HjelajyJN937Szy/ttnI8rFOYfC3c0pY0TmkMZwyXrwFSaBe9XOTCZYiO9+tkmUnQAfb0MTgO0QwjYxWnnKL0OrECtw/75G39vhsBZwUa+GF4WphIDRISeH155am2+X5Q2ZAFOSZs2XlW4BGeRy7I443Ph4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716294777; c=relaxed/simple; bh=NtA7od13HD7Pli3/q+ifW0EOOVFFsJcHPJ38M8BXsAI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bdJIxFN7EmygsDjvFnj99oa8AxdLK3b8AsUZxCJry88mCzzpi5XVIs3cz0k0qg18QCQcvX0R4A+zxoAGVofLyP4uViEGYKSW7PoHxHs9yUjQd8sJaUfn6njSIWjuEXP9rdOQbjekrniHmGRd9j6dyCmS3p0XIaxOH8pIhy1Z9AE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6f43ee95078so1498881b3a.1 for ; Tue, 21 May 2024 05:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716294775; x=1716899575; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=nI/mXlqANOhqgdkHXDjLDlKZGTapJdOEw0WjOmaMCT0=; b=HmnVlp80ZL7bgc9jP/R/HY4ZhKseqxOyx1ecCLQovmy3k3Uxbk9PXgp2YLWjyox8CV 0nMIPHxUqXRsM82GG0HG163sjkgM24iRaXiUBVJ6lc5w8Ho+2cN0hiONBz7aeInsMbnA KAGKx3ClT5M4Eb+PooKPBjl1iK/Sm2EvLCYWNDBSAGgVi/JFkkJe8BFKE4+a5vCruJxE s4ZKEyQmXJfoC85MNl1VjhOtgMvs3jFnlftuorhFnx073QTo0tfGyl5Sxydba0bsujPg D6xJGWBc4d7QoYRk592mWaoZFobrPvkkBkP7XRnUplIKz5fYJ+j2q9LJ3yYgp9TqqqmL qZ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716294775; x=1716899575; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nI/mXlqANOhqgdkHXDjLDlKZGTapJdOEw0WjOmaMCT0=; b=wN+q7fq/rRaF8/lXex+8sn7n/YC1vafALoQf4+KyJQfjivHYZNvNv8b8BCNYA8Ot3q hGDgsKKVcPOnvds5InTjdIQFmTfSuMvvwHj6+UewVrYIzdCeHpD0UvW9tPxxmffRrBpY PW2fhN6HKXb2NBduRZZL3DdSEuyiJxEHcLlijWhATR8MT+aK2c1WlOiKUab6yi8jFWFk fPToBXDqreqgwfDl7f2ypgV5ZHkdVku6Fe6Pt1jLmZMy2ldC3dWLNj+39DgBArBzAVfZ trSP2BQ6jb6jrap0qytOCg91Wo8VJKBXBTwHxMy2l5FDyoXCTdT+kDH0/PUcBE548Li7 h3Ew== X-Gm-Message-State: AOJu0Yywk6NT3qzrO/Dq6uOm37lCNE1oJubDfZVxJXmPYrFbv14MZGpa NyvPGOWrmyRjKL+WwXwDHifTM2DRm+WLeB9WkZMVMMFeDiFmlI31AORtnpWGBgQ= X-Google-Smtp-Source: AGHT+IHm79CnJsTEratj4745OYsnUPxhHISWM2VBOfdllH6IN3x+ZskAwOMzm39dJEjaOAGJctBhzw== X-Received: by 2002:a05:6a00:4f86:b0:6f3:e6ac:1a3f with SMTP id d2e1a72fcca58-6f4e02ad970mr37506234b3a.11.1716294774723; Tue, 21 May 2024 05:32:54 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf? ([2804:1b3:a7c2:f76a:f586:fbab:daec:c9bf]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2aa017dsm21267105b3a.96.2024.05.21.05.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 05:32:54 -0700 (PDT) Message-ID: Date: Tue, 21 May 2024 09:32:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/7] math: Fix isnanf128 static build To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Joseph Myers , Florian Weimer References: <20240402140644.2172819-1-adhemerval.zanella@linaro.org> <20240402140644.2172819-5-adhemerval.zanella@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/05/24 18:34, H.J. Lu wrote: > On Tue, Apr 2, 2024 at 7:06 AM Adhemerval Zanella > wrote: >> >> Some static implementation of float128 routines might call __isnanf128, >> which is not provided by the static object. >> >> Checked on x86_64-linux-gnu. >> --- >> sysdeps/ieee754/float128/float128_private.h | 2 +- >> sysdeps/ieee754/float128/s_isnanf128.c | 4 ++++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee754/float128/float128_private.h >> index 38a8bdd0fe..672bf3cccf 100644 >> --- a/sysdeps/ieee754/float128/float128_private.h >> +++ b/sysdeps/ieee754/float128/float128_private.h >> @@ -352,7 +352,7 @@ >> #define frexpl frexpf128 >> #define getpayloadl getpayloadf128 >> #define isinfl isinff128_do_not_use >> -#define isnanl isnanf128_do_not_use > > Why is this change needed? Will the issue be fixed by This is not required indeed, I will remove it. > > https://patchwork.sourceware.org/project/glibc/list/?series=34121 But unfortunately this patch does not fix the missing isnanf128 symbol on libc.a. > >> +#define isnanl isnanf128 >> #define ldexpl ldexpf128 >> #define llrintl llrintf128 >> #define llroundl llroundf128 >> diff --git a/sysdeps/ieee754/float128/s_isnanf128.c b/sysdeps/ieee754/float128/s_isnanf128.c >> index 59f71533ce..b73a4e80d7 100644 >> --- a/sysdeps/ieee754/float128/s_isnanf128.c >> +++ b/sysdeps/ieee754/float128/s_isnanf128.c >> @@ -11,7 +11,11 @@ >> #include "../ldbl-128/s_isnanl.c" >> #if !IS_IN (libm) >> #include >> +#ifdef SHARED >> hidden_ver (__isnanf128_impl, __isnanf128) >> +#else >> +strong_alias (__isnanf128_impl, __isnanf128) >> +#endif >> _weak_alias (__isnanf128_impl, isnanl) >> versioned_symbol (libc, __isnanf128_impl, __isnanf128, GLIBC_2_34); >> #if (SHLIB_COMPAT (libc, FLOAT128_VERSION_M, GLIBC_2_34)) >> -- >> 2.34.1 >> > >