From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 12F753858002 for ; Mon, 29 Mar 2021 21:53:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 12F753858002 Received: by mail-wr1-x434.google.com with SMTP id o16so14323641wrn.0 for ; Mon, 29 Mar 2021 14:53:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+wDAvvphtxAffsCZ2Ogy2AQ/c0BCwsur5hdXMrWhjBs=; b=DFPIVkeeDs0kU/OFwB1eOzEVOb9agRgc+/Srv4gDo0Vm3MU+QMGW4qJsj6jxp4BjLb VbnkiqCp6ri1lVlvtxYW1eanOOQC88KD7n3BjXKCRHKzinp+NzBq5YHaRAjN1S6dSHjZ pFkPh6o2GaW+3ryVk8PIiZZr4g5knFXrT6gGaJiC8qzs1K782iBQUsBdmCE/iJRklyTA qIyTATEj/m354pD+REzMjirZAh03/y1Wcd30acqSBNvE/F0LCbZNYUE97hZbHgkh6qsX 4HzgaZfO2Y5G+Myfqel1j53kATqdJIeTJ4yc7lijGr29QyeelfRyPhcT29/EPiiugPwZ U8bg== X-Gm-Message-State: AOAM532jQ1N8xwjXFrZz5ymB4rXTVImtyXR+x536LkmZnvnSGhWZUcez yJt00OrZkh+3XfA1W9czDME7HBCg+QE= X-Google-Smtp-Source: ABdhPJx16ZxgC9UZTF+qiW+VD5Ao/N7WGrUnCZW4aiY42A/ND/qIuWzXrEuX730wHy58rBn62Cog9w== X-Received: by 2002:a05:6000:18cd:: with SMTP id w13mr30304721wrq.20.1617054834158; Mon, 29 Mar 2021 14:53:54 -0700 (PDT) Received: from [192.168.0.160] ([170.253.36.171]) by smtp.gmail.com with ESMTPSA id j26sm31561981wrh.57.2021.03.29.14.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 14:53:53 -0700 (PDT) Subject: Re: [PATCH v2] stdio-common/printf-prs.c: Reword comment To: Adhemerval Zanella , libc-alpha@sourceware.org References: <830f204e-b1bd-424a-73b8-275b18582c7e@gmail.com> <20210324182915.29042-1-alx.manpages@gmail.com> <97ee7152-684a-1351-1ac6-f0d7b1b01ceb@linaro.org> From: "Alejandro Colomar (man-pages)" Message-ID: Date: Mon, 29 Mar 2021 23:53:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <97ee7152-684a-1351-1ac6-f0d7b1b01ceb@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2021 21:53:56 -0000 On 3/29/21 11:04 PM, Adhemerval Zanella wrote: > > > On 24/03/2021 15:29, Alejandro Colomar via Libc-alpha wrote: >> 'this' can be understood as the current parameter, but in this case it >> is meaning the other one, the one holding the width/precission. >> >> 'it' better describes that parameter, differentiating it from the >> one corresponding to the current specifier. >> >> Signed-off-by: Alejandro Colomar > > We don't use SCO, but rather Copyright assignment. The rest looks good > to me (although I am not a native speaker). I hope you don't need a copyright assignment for such a small change :). I guess a simple statement in this email that you can do as you wish with this patch should be enough. Anyway, I hereby assign copyright of this patch to the glibc copyright holder(s). Cheers, Alex > > Reviewed-by: Adhemerval Zanella > >> --- >> stdio-common/printf-prs.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/stdio-common/printf-prs.c b/stdio-common/printf-prs.c >> index 1d4e00553d..8ebf09a0a9 100644 >> --- a/stdio-common/printf-prs.c >> +++ b/stdio-common/printf-prs.c >> @@ -72,11 +72,11 @@ parse_printf_format (const char *fmt, size_t n, int *argtypes) >> /* Parse this spec. */ >> nargs += __parse_one_specmb (f, nargs, &spec, &max_ref_arg); >> >> - /* If the width is determined by an argument this is an int. */ >> + /* If the width is determined by an argument, it is an int. */ >> if (spec.width_arg != -1 && (size_t) spec.width_arg < n) >> argtypes[spec.width_arg] = PA_INT; >> >> - /* If the precision is determined by an argument this is an int. */ >> + /* If the precision is determined by an argument, it is an int. */ >> if (spec.prec_arg != -1 && (size_t) spec.prec_arg < n) >> argtypes[spec.prec_arg] = PA_INT; >> >> -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/