From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Aurelien Jarno <aurelien@aurel32.net>, libc-alpha@sourceware.org
Cc: nd@arm.com
Subject: Re: [PATCH] intl/tst-gettext: fix failure with newest msgfmt
Date: Fri, 26 Jan 2018 14:40:00 -0000 [thread overview]
Message-ID: <bda20fb9-d08d-75ec-0475-1ebfe517f47a@arm.com> (raw)
In-Reply-To: <20170826085756.6530-1-aurelien@aurel32.net>
On 26/08/17 09:57, Aurelien Jarno wrote:
> Since upstream gettext commit d13f165b83 (msgfmt: Remove
> POT-Creation-Date field from the header in the output.), msgfmt does not
> copy the POT-Creation-Date field in the header entry from the po file to
> the mo file anymore. This breaks the assumption that we can test gettext
> by comparing each message in the po files with the corresponding string
> return by gettext. This makes the intl/tst-gettext to fail.
>
> While it would have been possible to modify the po2test.awk script to
> also strip the line POT-Creation-Date field when creating the msgs.h
> file, it breaks tst-catgets which also uses it.
>
> Instead create a tst-gettext-de.po file from de.po by removing the
> POT-Creation-Date line. Another alternative would be to use a static
> tst-gettext-de.po file, but I guess the reason for using de.po is to
> also catch issues caused by newly added strings.
>
i updated msgfmt on my system and now i get
FAIL: intl/tst-gettext
because of this issue
https://savannah.gnu.org/bugs/?49654
the fix looks reasonable to me.
> Changelog:
> [BZ #21508]
> * catgets/Makefile ($(objpfx)de.msg): Depend on
> $(common-objpfx)intl/tst-gettext-de.po instead of $(..)po/de.po.
> * intl/Makefile ($(objpfx)tst-gettext-de.po): Generate
> intl/tst-gettext-de.po from po/de.po by removing the
> POT-Creation-Date line.
> ($(objpfx)msgs.h): Depend on $(objpfx)tst-gettext-de.po instead of
> ../po/de.po.
> * intl/tst-gettext.sh: Use ${objpfx}tst-gettext-de.po instead of
> ../po/de.po.
prev parent reply other threads:[~2018-01-26 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 8:58 Aurelien Jarno
2018-01-26 14:40 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda20fb9-d08d-75ec-0475-1ebfe517f47a@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).