From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55988 invoked by alias); 8 Nov 2019 22:21:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 55980 invoked by uid 89); 8 Nov 2019 22:21:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2 11/30] ldbl-128ibm-compat: Add error.h functions To: "Gabriel F. T. Gomes" , libc-alpha@sourceware.org References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-12-gabriel@inconstante.net.br> From: Paul E Murphy Message-ID: Date: Fri, 08 Nov 2019 22:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191025153410.15405-12-gabriel@inconstante.net.br> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-11/txt/msg00326.txt.bz2 On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote: > From: "Gabriel F. T. Gomes" > > No changes since v1. > > -- 8< -- > Use the recently added, internal functions, __error_at_line_internal and > __error_internal, to provide error.h functions that can take long double > arguments with IEEE binary128 format on platforms where long double can > also take double format or some non-IEEE format (currently, this means > powerpc64le). > > Tested for powerpc64le. > --- > misc/errorP.h | 28 ++++++++++ > sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 3 +- > sysdeps/ieee754/ldbl-128ibm-compat/Versions | 3 ++ > .../ldbl-128ibm-compat/ieee128-error.c | 51 +++++++++++++++++++ > 4 files changed, 84 insertions(+), 1 deletion(-) > create mode 100644 misc/errorP.h > create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/ieee128-error.c > > diff --git a/misc/errorP.h b/misc/errorP.h > new file mode 100644 > index 0000000000..c61c49cd61 > --- /dev/null > +++ b/misc/errorP.h > @@ -0,0 +1,28 @@ > +/* Prototypes for internal error.h functions. > + Copyright (C) 2018 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +void > +__error_internal (int status, int errnum, const char *message, > + va_list args, unsigned int mode_flags); > + > +void > +__error_at_line_internal (int status, int errnum, const char *file_name, > + unsigned int line_number, const char *message, > + va_list args, unsigned int mode_flags); A similar question to patch 10 in this series. These declarations appear in include/error.h too. > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Versions b/sysdeps/ieee754/ldbl-128ibm-compat/Versions OK. > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-error.c b/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-error.c OK.