From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24154 invoked by alias); 16 Jan 2018 22:56:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24139 invoked by uid 89); 16 Jan 2018 22:56:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=H*Ad:D*se X-HELO: mail-qk0-f170.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=LhhzuGjWT28VOebnLY9rhagDnklRSluRvIdObMfFvzQ=; b=OvgW/qdjMT7lC7d8RdESd0p8Bt9T4+QtY4Iqwl4ujMUEqFsImqsHlIw/pceqK/uguW c4ohFZniPWjKCdLl4YZpu+RhAczTNa4PV8zSyncULdyLm3AlhP5hTUe1Mx0SpEdUMcNf VN5k+F4HtCTWhCO+AJTzy350/N1XYT1nlFlZmnIq3ml0TyRUgzERRCM/6sqJ1d6Z7LlD chMEvJESlMUShwjFPBmtUZfjKFVG5tOA8z7wZMypWHbp/8cT72HQl9PNYhCRA1a4qPqh +CRjS9dxj4te3TP/xOCEF45pv3qBgck+Ip3J0gWL2WjbeXnEIBX5JNaelNluHV6AiPaG e4OA== X-Gm-Message-State: AKwxyteSZWza+wAJMBqXRYHnsplbmdC/RojWQ+rE7phOwXdy9DY1TU+o 7JtNwuBodW2/d6JIx+eSFvtSGo/6gdg= X-Google-Smtp-Source: ACJfBovaOt/cYmAcW54n+FQJa89U/S/82f0hKxCUykdG0r9cUjH5axY4TKwpOJEUCBUrAQnKUS/W0g== X-Received: by 10.55.197.219 with SMTP id k88mr46852320qkl.9.1516143385479; Tue, 16 Jan 2018 14:56:25 -0800 (PST) Subject: Re: [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343] From: Carlos O'Donell To: Arjun Shankar , libc-alpha@sourceware.org References: <20180104170250.GA72870@aloka.lostca.se> <2933759f-89f6-9a4d-e249-0d740e02c3bc@redhat.com> Message-ID: Date: Tue, 16 Jan 2018 22:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2933759f-89f6-9a4d-e249-0d740e02c3bc@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg00572.txt.bz2 On 01/16/2018 02:31 PM, Carlos O'Donell wrote: > Please rewrite this as: > > #define foo(...) \ > ({ \ > ... \ > }) > > The nested braces are less verbose IMHO. Note that requeset2size (above) can't use nested braces because it's involved in constant sized array expressions outside of a normal function. -- Cheers, Carlos.